Add bazel support for easier external integration #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
golovasteek
force-pushed
the
Support-bazel-build
branch
from
6f6353a to
44c2f3e
Compare
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
a-w50
reviewed
Nov 24, 2023
a-w50
reviewed
Nov 24, 2023
SirVer
approved these changes
Nov 24, 2023
|
Following the process that was suggested on the TSC meeting yesterday, we'd like to merge this best-effort support for Bazel which we have been using internally. Having it here makes it easier to keep in sync with future development of the framework and also makes it easy for others to use this in their own build processes. @corneliusclaussen @caller or any other: any inputs on this? |
I'm good with this, but I also think we should put a warning in the Readme or so stating that this build method is wip and your milage may vary. |
|
To get this merged pls look at the comments and especially at the caching key and mark as "Ready for review" when you are done. |
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
|
I've addressed all comments. |
corneliusclaussen
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many enterprise companies use Bazel to build their softwawre. Among them Qwello, BMW, Fernride.
Bazel is very good suitable for large repositories, because it ensures correctness of the incremental builds. And therefor even on large code bases CI can handle testing every commit.
To make adoption of Everest easier in such projects we may ship bazel rules for everest-framework.
In this PR bazel rules are added that allow to build everest-framework library, manager and controller.
The proposed usage is described in bazel/README.md.