Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use root licen[cs]e in python #53

Closed
wants to merge 1 commit into from
Closed

use root licen[cs]e in python #53

wants to merge 1 commit into from

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Nov 4, 2024 •
edited
Loading

@casperdcl
Copy link
Member Author

Art[ie]fact seems to have it correctly in the *.tar.gz now (https://github.com/ETSInitiative/PETSIRD/actions/runs/11664690131/artifacts/2140826080)

@gschramm
Copy link
Collaborator

gschramm commented Nov 4, 2024

awesome. let me know once pypi is updated, then I will try to get us on conda-forge.

KrisThielemans
KrisThielemans reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking this out on Windows gives me just a normal file containing ../LICENSE.txt, which is also how it is displayed on GitHub.

This makes me a little bit worried.

Maybe we should just do a plain copy...

@KrisThielemans KrisThielemans mentioned this pull request Nov 7, 2024
Merged
@KrisThielemans KrisThielemans deleted the py-lic branch November 7, 2024 08:48
@casperdcl
Copy link
Member Author

casperdcl commented Nov 7, 2024 •
edited
Loading

Windows isn't used for building distributions so it doesn't matter.

This is tested & working on GH Actions.

The GH web UI also renders symlink target paths by design.

@casperdcl casperdcl mentioned this pull request Nov 7, 2024
Open
@KrisThielemans
Copy link
Contributor

Windows isn't used for building distributions so it doesn't matter.

true, but if anyone checks out on Windows, it looks like a normal file. I also see https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows/59761201#59761201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisThielemans KrisThielemans KrisThielemans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

packaging of license file on pypi
3 participants
@casperdcl @gschramm @KrisThielemans