Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker installation #46

Conversation

johnstairs
Copy link
Contributor

Changes in this pull request

Updating Docker installation in devcontainer. The previous script came from an archived repository.

Testing performed

Docker working properly.

Related issues

Closes #45

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • The code builds and runs on my machine

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in the ETSI software (the Work) under the terms and conditions of the Apache-2.0 License.

Copy link
Contributor

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not qualified to reviews this one 😄. Go ahead and merge

@johnstairs johnstairs merged commit b49b6c8 into ETSInitiative:main Nov 1, 2024
1 check passed
@johnstairs johnstairs deleted the johnstairs/update-docker-outside-of-docker branch November 1, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode-dev-containers out-of-date
2 participants