Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix workflows #40

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix workflows #40

merged 3 commits into from
Oct 30, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Oct 30, 2024 •
edited
Loading

@casperdcl casperdcl self-assigned this Oct 30, 2024
@casperdcl casperdcl merged commit 417ee0f into main Oct 30, 2024
1 check passed
@casperdcl casperdcl deleted the fix-workflows branch October 30, 2024 05:42
@KrisThielemans
Copy link
Contributor

Thanks. I still think having the pypi upload as a different action would have been clearer, but fine.

However, we still have the same upload problem on main
https://github.com/ETSInitiative/PETSIRD/actions/runs/11587715198/job/32260307243#step:10:155

@KrisThielemans KrisThielemans mentioned this pull request Oct 30, 2024
Closed
@casperdcl casperdcl mentioned this pull request Oct 30, 2024
Merged
@KrisThielemans KrisThielemans mentioned this pull request Nov 1, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@casperdcl casperdcl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test pypi upload fails (using legacy?)
2 participants
@casperdcl @KrisThielemans