Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
  • Loading branch information
KrisThielemans and casperdcl authored Nov 1, 2024
1 parent a60beca commit 64e4d1c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
/cpp/build/
/python/petsird/
__pycache__/
build/
petsird.egg-info/
/python/build/
/python/petsird.egg*

# Common editor backups
/.vscode/
Expand Down
16 changes: 7 additions & 9 deletions python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@

This directory contains some Python example code to read/write PETSIRD data.

## Pre-installation
## Install

You will need the Python files generated by yardl. You have a few options.

### Use PyPI
Some python code is generated by `yardl` and included in the PyPI distribution.

```sh
python3 -m venv ~/petsirdenv
Expand All @@ -19,12 +17,12 @@ pip install petsird
(This option needs the `yardl` binary, either download it, or use our devcontainer or GitHub CodeSpace.)

You need to `yardl generate` in the `model` directory first. This will create the Python package files in a `petsird`
subfolder. Optionally install those into your venv
subfolder.

```sh
python3 -m venv ~/petsirdenv
source ~/petsirdenv/bin/activate
cd python
pip install .
cd ../model
yardl generate
pip install --editable ../python
```

## Usage
Expand Down
9 changes: 5 additions & 4 deletions python/README.pypi.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# PETSIRD Python SDK

The [Emission Tomography Standardization Initiative (ETSI)](https://etsinitiative.org/)
is working towards establishing a standard for PET Raw Data, called PETSIRD ("PET ETSI Raw Data").
is working towards establishing a standard for PET Raw Data, called PETSIRD ("Positron Emission Tomography Standardization Initiative Raw Data").

This python package contains the python SDK to read/write PETSIRD data.
Read & write PETSIRD data in Python.

Examples for how to use this package are available at
https://github.com/ETSInitiative/PETSIRD/tree/main/python
## Examples

See [ETSInitiative/PETSIRD:python](https://github.com/ETSInitiative/PETSIRD/tree/main/python).

0 comments on commit 64e4d1c

Please sign in to comment.