Skip to content

Conversation

@aallier
Copy link
Contributor

@aallier aallier commented Mar 16, 2022

No description provided.

@aallier aallier added the RFR label Mar 16, 2022
@aallier aallier changed the title 3.0 EB-0 3.0 Mar 16, 2022
@etsglobalbv-bot
Copy link

I was unable to add the LogBundle component to the Jira ticket. Please ensure the component exists in Jira.

1 similar comment
@etsglobalbv-bot
Copy link

I was unable to add the LogBundle component to the Jira ticket. Please ensure the component exists in Jira.

@etsglobalbv-bot
Copy link

I was unable to add the LogBundle component to the Jira ticket. Please ensure the component exists in Jira.

@aallier aallier requested a review from ch3ric March 18, 2022 15:39
@etsglobalbv-bot
Copy link

I was unable to add the LogBundle component to the Jira ticket. Please ensure the component exists in Jira.

*
* @internal
*/
final class LoggerAwarePass implements CompilerPassInterface
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 not needed since Symfony 4.2 symfony/symfony@afda3c8

{
public function build(ContainerBuilder $container): void
{
$container->addCompilerPass(new LoggerAwarePass());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 not needed since Symfony 4.2 symfony/symfony@afda3c8

@ch3ric ch3ric changed the title EB-0 3.0 EB-20134 3.0 Mar 21, 2022
@aallier aallier merged commit ed13011 into master Mar 21, 2022
@aallier aallier deleted the 3.0 branch March 21, 2022 13:21
Copy link

@ch3ric ch3ric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #22
✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants