Fix #45 correctly reinstate nullable unique constraints #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the unique/unique_together constraint is reinstated exactly the same as the one that was dropped earlier in `_alter_field` This fixes both cases described on the bug report, that is when `AlterField` modifies a column which is: 1) individually `unique=True` as well as `null=True` 2) in a `unique_together` where at least 1 column is nullable
sparrowt
changed the title
|
The unit tests for this project (including those added by this PR) are passing ✔️ Though I did notice that they are now run with |
|
Great work, thank you! The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the unique/unique_together constraint which is reinstated, is exactly the same as the one that was dropped earlier on in
_alter_fieldbefore e.g. altering the column type.This fixes both cases described on the bug report, i.e. when
AlterFieldmodifies a column which is:unique=Trueas well asnull=Trueunique_togetherwhere at least 1 column is nullableFirst commit adds tests for both cases which fail without the fix & pass with it.