Fix DROP index vs constraint issue (#38) #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_constraint_names` return value includes unique indexes even if these are not actual constraints. Trying to drop these using `sql_delete_unique` (ALTER TABLE ... DROP CONSTRAINT ...) will fail because it is an index, not a constraint. Instead explicitly deal with unique indexes separately.
|
Looks good! Could you add a test model along with 2 migrations and some test that tests this? |
|
Added 👍 The successful running of the 2 new test migrations should be sufficient to test this - not sure what we would be testing in an explicit test case method? |
|
Looks good, thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value from
_constraint_namesincludes unique indexes even if these are not actual constraints.Therefore trying to drop these using
sql_delete_unique("ALTER TABLE ... DROP CONSTRAINT ...") will fail because it is an index, not a constraint.Instead explicitly deal with unique indexes separately.
With this patch I can no longer repro the issue at #38