-
Notifications
You must be signed in to change notification settings - Fork 93
Add calibration guide and settings overview to documentation #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdds a new calibration documentation page and updates existing configuration docs to describe RSSI calibration, receiver-side RSSI adjustment (rxAdj), environmental factors, beacon forgetting/idle retention, and an image change in initial settings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
images/calibration_settings.pngis excluded by!**/*.png
📒 Files selected for processing (2)
configuration/calibration.md(1 hunks)configuration/settings.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
configuration/calibration.md
[grammar] ~19-~19: Ensure spelling is correct
Context: ...er that value in Rssi expected from a 0dBm transmitter at 1 meter on every node ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~24-~24: Ensure spelling is correct
Context: ...ur deployment. ## Rssi expected from a 0dBm transmitter at 1 meter This value esta...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
configuration/settings.md
[grammar] ~42-~42: Ensure spelling is correct
Context: ... or dev boards. * Rssi expected from a 0dBm transmitter at 1 meter - Reference RSSI...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🔇 Additional comments (3)
configuration/settings.md (1)
40-45: Calibration section is well-structured and clearly references the new guide.The restructuring appropriately introduces the new calibration.md guide and organizes the four key parameters (RSSI, Factor, rxAdj, Forget beacon) with concise descriptions. The link to the detailed guide and the brief parameter summaries work well together.
configuration/calibration.md (2)
13-13: Verify the calibration settings image is available.Line 13 references
/images/calibration_settings.png. Please confirm this image has been added to the repository at that path, as the documentation depends on it rendering correctly.
15-65: Excellent documentation structure and practical guidance.The calibration guide is well-organized, actionable, and comprehensive. The quick procedure (lines 15–22) provides clear step-by-step instructions, the parameter sections (lines 24–59) explain each setting with practical context, and the tips section (lines 61–65) adds real-world value. The explanations of
rxAdjhardware normalization (lines 39–55) are particularly thorough and should help users with mixed hardware deployments. Cross-references to settings.md terminology are consistent, and the overall flow supports both new and experienced users.
eeb3130 to
78ead16
Compare
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.