Skip to content

Removed unused code from Dataset class#2963

Open
schlunma wants to merge 3 commits intomainfrom
remove_unused_code
Open

Removed unused code from Dataset class#2963
schlunma wants to merge 3 commits intomainfrom
remove_unused_code

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 2, 2026

Description

Removes code that is not relevant anymore because #2769 has been closed.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.14.0 milestone Feb 2, 2026
@schlunma schlunma requested a review from bouweandela February 2, 2026 11:10
@schlunma schlunma added the enhancement New feature or request label Feb 2, 2026
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (2792ad1) to head (ef9d4d8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2963      +/-   ##
==========================================
- Coverage   95.62%   95.61%   -0.01%     
==========================================
  Files         266      266              
  Lines       15601    15585      -16     
==========================================
- Hits        14918    14902      -16     
  Misses        683      683              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, Manu - @bouweandela I reckon this one's good to be merged 🍻

@schlunma

This comment was marked as outdated.

@schlunma
Copy link
Contributor Author

schlunma commented Feb 5, 2026

I will merge this by the end of the week if there are no objections to proceed with the release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants