Skip to content

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 30, 2025

Description

Closes #2615


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added this to the v2.12.0 milestone Jan 30, 2025
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (2405d95) to head (d0e090a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2649   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         255      255           
  Lines       14880    14880           
=======================================
  Hits        14146    14146           
  Misses        734      734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valeriupredoi
Copy link
Contributor Author

cheers @mathause - figured that'd be OK to hardcode the pkg name, as @bouweandela mentioned, it's not like we change the package name every week or so 😁

@valeriupredoi valeriupredoi merged commit c2f1029 into main Feb 4, 2025
7 checks passed
@valeriupredoi valeriupredoi deleted the restrict_GAs_from_forks branch February 4, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

don't run scheduled tests in forks

3 participants