-
Notifications
You must be signed in to change notification settings - Fork 41
Added cumulative sum preprocessor #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 255 255
Lines 14793 14824 +31
=======================================
+ Hits 14052 14082 +30
- Misses 741 742 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice already @schlunma! I left a few questions.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Description
This PR adds the preprocessor
cumulative_sum
, which calculates cumulative sums along a given coordinate. Corresponding numpy function:np.cumsum
.Example:
@bouweandela This is necessary for a REF diagnostic which I am currently developing (TCRE), so it would be great to have this in v2.12.0!
Link to documentation: https://esmvaltool--2642.org.readthedocs.build/projects/ESMValCore/en/2642/recipe/preprocessor.html#cumulative-sum
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: