-
Notifications
You must be signed in to change notification settings - Fork 340
post-5.4.n00: New crop calendar inputs and updated params (omni02) #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: post-5.4
Are you sure you want to change the base?
Conversation
Derived from half-degree run started 1959-01-01, forced with CRU-JRA, at tag alpha-ctsm5.4.CMIP7.15.ctsm5.3.079. Growing seasons defined by files [sh]dates_ggcmi_crop_calendar_phase3_v1.01_nninterp-hcru_hcru_mt13.2000-2000.20230728_165845.nc. Maximum growing season length in generate_gdds.py derived from mxmat in clm60_params.crop_omni02.c251120.nc with no 'cushion'. generate_gdds.py first season 1995 and last season 2005.
Derived from half-degree run started 1959-01-01, forced with CRU-JRA, at tag alpha-ctsm5.4.CMIP7.15.ctsm5.3.079. generate_gdd20_baseline -v GDDB20 -y1 1995 -yN 2005.
…leName_gdd20_baseline.
slevis-lmwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsrabin I looked at your changes. They seem simple enough. Approving.
ekluzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple comments/questions, but this looks good to go. My comments should be addressed in a possible later step. Most of the work was in creating the new datasets that you point to here. So this is deceptively simple compared to the loads of work it took you to get the datasets ready.
| <stream_fldFileName_gdd20_baseline cropcals_rx_adapt=".true." stream_gdd20_seasons=".false.">lnd/clm2/cropdata/calendars/processed/gdd20_baseline.c251120.tweaked_latlons.nc</stream_fldFileName_gdd20_baseline> | ||
| <stream_fldFileName_gdd20_baseline cropcals_rx_adapt=".true." stream_gdd20_seasons=".false." lnd_tuning_mode="clm4_5_GSWP3v1">lnd/clm2/cropdata/calendars/processed/20230714_cropcals_pr2_1deg.actually2deg.1980-2009.from_GDDB20.interpd_halfdeg.tweaked_latlons.nc</stream_fldFileName_gdd20_baseline> | ||
| <stream_fldFileName_gdd20_baseline cropcals_rx_adapt=".true." stream_gdd20_seasons=".false." lnd_tuning_mode="clm5_0_GSWP3v1">lnd/clm2/cropdata/calendars/processed/20230714_cropcals_pr2_1deg.actually2deg.1980-2009.from_GDDB20.interpd_halfdeg.tweaked_latlons.nc</stream_fldFileName_gdd20_baseline> | ||
| <stream_fldFileName_gdd20_baseline cropcals_rx_adapt=".true." stream_gdd20_seasons=".false." lnd_tuning_mode="clm6_0_GSWP3v1">lnd/clm2/cropdata/calendars/processed/20230714_cropcals_pr2_1deg.actually2deg.1980-2009.from_GDDB20.interpd_halfdeg.tweaked_latlons.nc</stream_fldFileName_gdd20_baseline> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This likely means another step, for later, but you'll also want a version for clm6_0 with CRUJRA2024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it looks like the default for clm4_5 in compsets is GSWP3, but I think we actually used CRUv7 back then. And I think we might change the compsets to reflect that.
However, since this is clm4_5 -- it's also not something to worry about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekluzek Won't CRUJRA2024 automatically get the new dataset (with c251120 in the filename) because it's not one of the GSWP3v1 tuning modes?
Description of changes
Updated crop maturity requirements and GDD20 baselines using improved scripts and CRU-JRA forcing.
Calibrating crop parameters looking at yield for about 1995-2005 while minimizing failed seasons:
arootichanges.Soybean: It's low for this period but nothing I tried helped much. Removing mxmat helped a bit, so increase max growing season length from 150 days to 180 days.Accidentally did this for rice instead! Will revert in next crop parameter PR.arootichanges. Need a pretty big drop in yields and this didn't do it in my test, but that was without grainfill triggering max LAI and thus much more failed crop area. (There were no crop phase parameter changes in CLM5.)Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? Yes: Any CLM6 crop compset.
Any User Interface Changes (namelist or namelist defaults changes)? New:
clm6_0paramfilestream_fldfilename_cultivar_gddsstream_gdd20_seasons = .false.stream_fldFileName_gdd20_baseline.Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
aux_clmin progress