Skip to content

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Sep 3, 2025

Description of changes

Experimental branch for working with using MPI_SCAN for the decomposition to get the gridcell offsets.

This is starting off as very experimental with calls to asserts to make sure it gives the same results as before.

Specific notes

Contributors other than yourself, if any: @johnmauf

CTSM Issues Fixed (include github issue #):
Work for #2995
Fixes #3370

Are answers expected to change (and if so in what way)? no

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: Running the decomp_init testlist

ekluzek added 30 commits June 26, 2025 13:47
…elf tests to exit after running in initialization
…_exit_after_self_tests, change the self tests testmod so that its about initialization, this works with a compset with SATM, but hangs -- because nothing stops the run
 Conflicts:
	cime_config/testdefs/testmods_dirs/clm/run_self_tests/shell_commands
…branch

 Conflicts:
	cime_config/testdefs/testmods_dirs/clm/run_self_tests/shell_commands
…nd use newunit rather than a hardcoded file unit to make it more robust, it wasn't showing any output before
…urning off ncdio_pio testing for the purposes of decompInit work
…k to make it more obvious what is going on because each task should be similar
… out, and so that the self-tests can run to completion afterwards

 Conflicts:
	src/cpl/nuopc/lnd_comp_nuopc.F90
	src/main/clm_initializeMod.F90
…Init_lnd timers to around the calls rather than for the entire subroutine, because the things at the top that may abort will then have a broken timer

 Conflicts:
	src/cpl/nuopc/lnd_comp_nuopc.F90
	src/main/decompInitMod.F90
…_exit_after_self_tests, change the self tests testmod so that its about initialization, this works with a compset with SATM, but hangs -- because nothing stops the run

 Conflicts:
	cime_config/testdefs/testmods_dirs/clm/run_self_tests/README
	cime_config/testdefs/testmods_dirs/clm/run_self_tests/shell_commands
	cime_config/testdefs/testmods_dirs/clm/run_self_tests/user_nl_clm
	src/cpl/nuopc/lnd_comp_nuopc.F90
… of atm_present and adjustments to how send_to_atm was done
…hould be

 Conflicts:
	src/main/clm_initializeMod.F90
…lly some timers accidentally brought in again
@wwieder
Copy link
Contributor

wwieder commented Oct 6, 2025

Hey Erik. I appreciate all of your work on the SIF project. How close are you to being able to wrap it up?

@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 6, 2025

Hey Erik. I appreciate all of your work on the SIF project. How close are you to being able to wrap it up?

I'm working towards getting the branches to a point where the work is complete and it's just turning the testing crank and responding to reviews that's left to do. I want to get to that (or close to that) by the Tuesday morning meeting where we can talk about what's left to do.

 Conflicts:
	bld/namelist_files/namelist_definition_ctsm.xml
	cime_config/testdefs/testmods_dirs/clm/for_testing_fastsetup_bypassrun/user_nl_clm
	cime_config/testdefs/testmods_dirs/clm/run_self_tests/user_nl_clm
	src/cpl/nuopc/lnd_comp_nuopc.F90
	src/main/clm_initializeMod.F90
	src/main/controlMod.F90
	src/self_tests/SelfTestDriver.F90
@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 8, 2025

0.2 weeks in sprint 23.

@ekluzek ekluzek moved this from In Progress to Stalled in LMWG: Sprint Planning Board Oct 8, 2025
@ekluzek ekluzek linked an issue Oct 8, 2025 that may be closed by this pull request
@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 21, 2025

From meeting with @johnmauff @briandobbins and @wwieder and I we decided I will cherry-pick just the updates to the decomp files (so just three source files). And bring that in soon, as a secondary priority to other work. The other testing PR's we will want to bring in, but they can be secondary to other work, and likely will need to wait until after the CESM3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability performance idea or PR to improve performance (e.g. throughput, memory)

Projects

Status: Stalled

Development

Successfully merging this pull request may close these issues.

Deallocate memory in lnd_set_decomp_and_domain

5 participants