ctsm5.3.083: Pass nutrient supplementation status to FATES #3348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgknox
added
FATES API update
|
Test ERS_D_Ld60.f45_f45_mg37.I2000Clm50FatesCruRsGs.derecho_intel.clm-Fates all PASS, didn't compare with base yet |
glemieux
moved this from Under Review
to Stuck
in FATES Pull Request Planning and Status
5 tasks
glemieux
moved this from Hold
to Final Testing
in FATES Pull Request Planning and Status
ekluzek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This set of changes passes nitrogen supplementation status to FATES. This status is needed when deciding whether or not to dynamically adjust leaf to fine root ratios based on nutrient storage. This status prevents plants from reducing root mass while soils have artificially high nitrogen during supplementation.
Specific notes
This is coupled with FATES PR: 1443
Contributors other than yourself, if any: @sharma-bharat @glemieux @walkeranthonyp
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No, this should have not impact on answers on any configuration. This will only be relevant when we fully couple FATES-CLM-CN.
Any User Interface Changes (namelist or namelist defaults changes)?
No
Does this create a need to change or add documentation? Did you do so?
Not yet needed, no N limitations with FATES
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).