ctsm5.3.055: Remove broken FTorch submodule

[samsrabin]

Description of changes

As of ctsm5.3.051 (#3125), bin/git-fleximod checkout -o results in an unclean state, which prevents the documentation from deploying. This PR resolves the issue. It also edits a couple of GitHub workflows to catch such problems in the future.

Additionally, ctsm5.3.051 did not bring in the version of CMEPS required for FTorch to build properly—see #3214. Fixing it is going to be a big task, so for now we're just removing it. Issue to add it back: #3228

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

• Resolves build-and-deploy failure at ctsm5.3.053 #3210
• Resolves Build fails with FTorch checked out #3214

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: GitHub workflows, plus:

• SMS_D.f10_f10_mg37.I2000Clm60BgcCrop.izumi_nag.clm-crop to check build

[ekluzek]

This is great and good to come in now. This was a great catch by @samsrabin and good to have in place.

[ekluzek]

Oh, shouldn't this be going to b4b-dev?

[samsrabin]

Thanks @ekluzek! Per discussion just now we'll put this on master. I'll wait until #3212 before doing this, just because I tested that one without this. I don't think there'll be side effects of this but who knows.

[samsrabin]

#3214 means this is more complicated now. I'm passing it off to @ekluzek to fix, because I think updating CMEPS to cmeps1.0.51 is going to require other submodule updates.

See #3214

[wwieder]

Hey all, I think this is good work, but I don't really understand why it's suddenly at the top of the project board (not where on our sprint planning board)? It seems like this is ready to go, and OK to move it. But I'm kind of surprised it was prioritized when it's not really a required focus for CESM3 / CLM6 release.

[wwieder]

Reading this a little more carefully it seems like this is fixing submodules needed for documentation, which is required for CLM6. I guess I was confused by the FTorch capabilities (which don't seem critical for CESM3).

[samsrabin]

@wwieder Yeah, Erik thought it would be easy to bring in, so he did (ctsm5.3.051) but later I realized it was broken. The decision from this morning is we're just going to remove it. Changing the title of this PR to reflect that.

[ekluzek]

Cool, this does the obvious thing with removing FTorch, and it does a few documentation things which is great.

I'm marking approve. The one substantial thing that I request is to check that doc-builder is in place, rather than doing the git-fleximod update in the testing.sh script.

But, thanks for putting this together and having it ready to go.