User control over snow thermal conductivity scheme over glaciers #3072

wwieder · 2025-04-16T18:51:39Z

Description of changes

Test runs with F and B cases for CESM3 show excessive melt and low albedo over Greenland. Reverting to the Jordan1991 snow thermal conductivity scheme seems to help address these biases, but also appears to slow snowmelt across the Arctic and prevent vegetation growth. This PR will allow different schemes over glacier and non-glacier land units (Jordan and Sturm, respectively).

Specific notes

Current PR is intended for testing only. If this is something we want to merge it's likely better to allow namelist control over schemes used oven glacier and non-glacier land units?

Contributors other than yourself, if any:
@olyson

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

Yes, should increase albedo and snowpack over glacier regions

Testing performed, if any:

running I case to evaluate changes

Additional tasks:

Fix lake bug Bill identified below
add namelist option for method used over glacier land units

ekluzek

This makes sense as a starting hack.

billsacks

Looks great - thanks for taking care of this @wwieder !

(For future reference there is a col%lun_itype variable for convenience that prevents you from needing to get col%landunit and then lun%itype, but what you have is equivalent and totally fine, too.)

billsacks · 2025-04-16T19:11:50Z

And yes, I agree with this approach:

it's likely better to allow namelist control over schemes used oven glacier and non-glacier land units?

i.e., having separate namelist variables for those two.

olyson

Looks good thanks.

…list items for gld and lake, remove the unneeded check for validity as the validate check at the end covers this

…acier

…JordanGlacier

…acier

src/biogeophys/LakeFluxesMod.F90

This reverts commit e469029.

…around moving use statements for error and logging to the top as well as removing subname as errMsg gives the file and line number and doesn't need to be changed, this makes some progress on ESCOMP#1452

ekluzek · 2025-05-01T18:02:06Z

This is passing testing other than the st_archive issue, so I'm merging it in now.

Merge b4bdev 20250509 Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log: - Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2 Update docs infrastructure - Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c Update externals to cesm3_0_alpha06c - Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier User control over snow thermal conductivity scheme over glaciers

Merge b4bdev 20250509 Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log: - Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2 Update docs infrastructure - Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c Update externals to cesm3_0_alpha06c - Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier User control over snow thermal conductivity scheme over glaciers Conflicts: src/biogeochem/CNFireNoFireMod.F90

Merge b4bdev 20250509 Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log: - Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2 Update docs infrastructure - Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c Update externals to cesm3_0_alpha06c - Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier User control over snow thermal conductivity scheme over glaciers

hacky way to address ESCOMP#3068

cb6e923

wwieder added the science Enhancement to or bug impacting science label Apr 16, 2025

wwieder requested a review from olyson April 16, 2025 18:51

wwieder self-assigned this Apr 16, 2025

wwieder changed the title ~~hacky way to address #3068~~ hacky way to address #3071 Apr 16, 2025

wwieder mentioned this pull request Apr 16, 2025

Option to use Jordan1991 over glacier land units #3071

Closed

ekluzek approved these changes Apr 16, 2025

View reviewed changes

ekluzek added enhancement new capability or improved behavior of existing capability investigation Needs to be verified and more investigation into what's going on. PR status: needs testing non-bfb Changes answers (incl. adding tests) labels Apr 16, 2025

billsacks approved these changes Apr 16, 2025

View reviewed changes

olyson approved these changes Apr 16, 2025

View reviewed changes

wwieder mentioned this pull request Apr 16, 2025

ctsm53026_UpLimDestMet_jordanIce_pSASU_test NCAR/LMWG_dev#97

Open

wwieder changed the title ~~hacky way to address #3071~~ user control over snow thermal conductivity scheme over glacies Apr 17, 2025

wwieder added this to the ctsm5.4.0: CMIP7 Datasets milestone Apr 17, 2025

github-project-automation bot added this to CTSM: ctsm5.4.0 minor version update (CMIP7 datasets) Apr 17, 2025

github-project-automation bot moved this to Status not assigned in CTSM: ctsm5.4.0 minor version update (CMIP7 datasets) Apr 17, 2025

wwieder added this to CTSM: Upcoming tags Apr 17, 2025

github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Apr 17, 2025

wwieder moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Apr 17, 2025

wwieder removed this from CTSM: ctsm5.4.0 minor version update (CMIP7 datasets) Apr 17, 2025

wwieder added this to LMWG: Sprint Planning Board Apr 17, 2025

github-project-automation bot moved this to Todo in LMWG: Sprint Planning Board Apr 17, 2025

github-project-automation bot added this to CTSM: ctsm5.4.0 minor version update (CMIP7 datasets) Apr 17, 2025

github-project-automation bot moved this to Status not assigned in CTSM: ctsm5.4.0 minor version update (CMIP7 datasets) Apr 17, 2025

wwieder removed this from CTSM: ctsm5.4.0 minor version update (CMIP7 datasets) Apr 17, 2025

ekluzek changed the title ~~user control over snow thermal conductivity scheme over glacies~~ User control over snow thermal conductivity scheme over glaciers Apr 17, 2025

github-project-automation bot added this to CTSM: ctsm5.4.0 minor version update (CMIP7 datasets) Apr 17, 2025

ekluzek and others added 3 commits April 25, 2025 23:17

Merge remote-tracking branch 'escomp/b4b-dev' into JordanGlacier

065635a

Add the needed add_default calls for the new snow_thermal_cond_* name…

0464df1

…list items for gld and lake, remove the unneeded check for validity as the validate check at the end covers this

Merge branch 'master' of https://github.com/ESCOMP/CTSM into JordanGl…

b0793c2

…acier

wwieder mentioned this pull request Apr 29, 2025

CTSM5.4 tests: snowTherm_100: ctsm53041_54surfdata_snowTherm_100_[AD, SASU, pSASU, hist] NCAR/LMWG_dev#100

Open

wwieder and others added 3 commits April 29, 2025 09:26

error logs fail to build, removing

e469029

Merge branch 'JordanGlacier' of https://github.com/wwieder/CTSM into …

c077a43

…JordanGlacier

Merge branch 'JordanGlacier' of github.com:wwieder/CTSM into JordanGl…

715f256

…acier

ekluzek reviewed Apr 29, 2025

View reviewed changes

src/biogeophys/LakeFluxesMod.F90 Outdated Show resolved Hide resolved

ekluzek added 3 commits April 29, 2025 10:44

Revert "error logs fail to build, removing"

81b2dfa

This reverts commit e469029.

Add in module use statements needed so the error checks will build

f9ac7ac

Similar changes that I brought in for LakeFluxes and SoilTemperature …

bd5e550

…around moving use statements for error and logging to the top as well as removing subname as errMsg gives the file and line number and doesn't need to be changed, this makes some progress on ESCOMP#1452

wwieder moved this from Todo to In Progress in LMWG: Sprint Planning Board Apr 29, 2025

wwieder assigned ekluzek Apr 29, 2025

ekluzek merged commit e4750c0 into ESCOMP:b4b-dev May 1, 2025
3 checks passed

github-project-automation bot moved this from In progress - b4b-dev to Done (non release/external) in CTSM: Upcoming tags May 1, 2025

github-project-automation bot moved this from Status not assigned to Done in CTSM: ctsm5.4.0 minor version update (CMIP7 datasets) May 1, 2025

github-project-automation bot moved this from In Progress to Done in LMWG: Sprint Planning Board May 1, 2025

ekluzek deleted the JordanGlacier branch May 1, 2025 18:05

wwieder mentioned this pull request May 6, 2025

PPE 5.4 baseline: ctsm53041_54surfdata_PPEbaseline_101_[AD,SASU,pSASU,HIST] NCAR/LMWG_dev#101

Open

wwieder modified the milestones: ctsm5.4.0: CMIP7 Datasets, cesm3_0_beta07 May 8, 2025

slevis-lmwg mentioned this pull request May 9, 2025

Merge b4bdev 20250509 #3123

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

User control over snow thermal conductivity scheme over glaciers #3072

User control over snow thermal conductivity scheme over glaciers #3072

Uh oh!

wwieder commented Apr 16, 2025 •

edited

Loading

Uh oh!

ekluzek left a comment

Uh oh!

billsacks left a comment

Uh oh!

billsacks commented Apr 16, 2025

Uh oh!

olyson left a comment

Uh oh!

Uh oh!

ekluzek commented May 1, 2025

Uh oh!

Uh oh!

Uh oh!

User control over snow thermal conductivity scheme over glaciers #3072

User control over snow thermal conductivity scheme over glaciers #3072

Uh oh!

Conversation

wwieder commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Specific notes

Uh oh!

ekluzek left a comment

Choose a reason for hiding this comment

Uh oh!

billsacks left a comment

Choose a reason for hiding this comment

Uh oh!

billsacks commented Apr 16, 2025

Uh oh!

olyson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ekluzek commented May 1, 2025

Uh oh!

Uh oh!

Uh oh!

wwieder commented Apr 16, 2025 •

edited

Loading