Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change history time to be equal to the middle of the time bounds #2838

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Oct 18, 2024

Description of changes

This PR subsets the scope of issue #1059 and PR #2445 as a result of the October 2024 conversation in #2445.
This PR changes history time to be equal to the middle of the time bounds.
This PR does not put instantaneous fields on their own separate history files.

I will also bring submodule changes from ESCOMP/MOSART#106 (was ESCOMP/MOSART#69) and ESCOMP/RTM#39.

Specific notes

Contributors other than yourself, if any:

Are answers expected to change (and if so in what way)?
No.

Does this create a need to change or add documentation? Did you do so?
Maybe. No.

Testing performed, if any:
Plan to run aux_clm, mosart, rtm test-suites.

slevis-lmwg and others added 3 commits March 28, 2024 17:27
...and other mods that I'm preserving from closed PR ESCOMP#2019, such as
- changes to long_names and
- treating avgflag as a tape (not field) trait for 'I' and 'L' tapes
@slevis-lmwg slevis-lmwg self-assigned this Oct 18, 2024
@slevis-lmwg slevis-lmwg added enhancement new capability or improved behavior of existing capability bfb bit-for-bit size: small labels Oct 18, 2024
@slevis-lmwg
Copy link
Contributor Author

I submitted this manual test to confirm that the committed modifications work as intended:
./create_test SMS_Lm1.f10_f10_mg37.I1850Clm60BgcCropCmip6waccm.derecho_gnu.clm-basic -c /glade/campaign/cgd/tss/ctsm_baselines/ctsm5.3.009
Check on Friday.

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 18, 2024

The previous test completed its 1 month and the monthly output looked good, but there were annual history files that I could not tell. So I started another test (default is Ly1, but I changed to Ly2) and I added hist_avgflag_pertape(6) = 'I' to see what happens:
SMS_Ly2_Mmpi-serial.1x1_brazil.IHistClm60BgcQianRs.derecho_intel.clm-output_bgc_highfreq

PASS

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 18, 2024

I updated the submodules to point to ESCOMP/MOSART#106 and ESCOMP/RTM#39 and submitted the three corresponding test-suites:

OK ./run_sys_tests -s rtm -c rtm1_0_80-ctsm5.2.029 --skip-generate
FAIL ./run_sys_tests -s mosart -c mosart1.1.02-ctsm5.2.029 --skip-generate
FAIL ./run_sys_tests -s aux_clm -c ctsm5.3.009 --skip-generate

All the rtm cases differ from the baseline BUT only the time variable.
All the mosart cases failed to build.
Some of the ctsm cases failed to build.
I will investigate on Monday...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability size: small
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant