Remove unused variable elevclass_o in mkglcmecMod.F90 #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now also started aux_clm on izumi. |
ekluzek
requested changes
Sep 30, 2024
There was a problem hiding this comment.
@slevis-lmwg I actually recommend that you remove elevclass_o completly rather than allocate it. There seems to be no reason for it to exist.
In terms of testing I would make an f09 surface dataset and also run the MKSURFDATAESMF_P128x1.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel and compare it to the baseline. That's the only aux_clm test that's going to exercise this bit of code.
|
@ekluzek, thank you for noticing that the variable could be removed altogether.
|
|
The above tests passed, so this is ready. |
|
@ekluzek thank you, I followed your suggestions and the tests pass. Let me know if you can think of anything else before approving. |
slevis-lmwg
changed the title
olyson
approved these changes
Oct 1, 2024
slevis-lmwg
added
the
PR status: ready
ekluzek
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
User found that the mksurfdata_esmf tool fails on a certain computer with this error:
Program received signal SIGSEGV: Segmentation fault - invalid memory reference.and works when elevclass_o gets allocated before use in mkglcmecMod.F90.
Original post here:
https://bb.cgd.ucar.edu/cesm/threads/mksurfdata_esmf-done-around-glcmec.9624/post-57405
Specific notes
Contributors other than yourself, if any:
@olyson and @YuanSun-UoM
CTSM Issues Fixed (include github issue #):
Resolves #2802
Are answers expected to change (and if so in what way)?
No.
Any User Interface Changes (namelist or namelist defaults changes)?
No.
Does this create a need to change or add documentation? Did you do so?
No.
Testing performed, if any:
As posted in issue #2802, I'm testing on derecho...
PASS qsub mksurfdata_jobscript_single_2000.sh so as to compare today's output to that generated yesterday, now in /glade/derecho/scratch/slevis/temp_work/new_rawdata/tools/mksurfdata_esmf/bkup_T42
PASS ./run_ctsm_py_tests -s and ./run_ctsm_py_tests -u
PASS make black and make lint
PASS build-namelist_test.pl
IN PROGRESS aux_clm