Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check in build-namelist_test.pl #2678

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

mvdebolskiy
Copy link
Contributor

@mvdebolskiy mvdebolskiy commented Aug 8, 2024

Description of changes

Added a check in failtest, warntest, finidat_files, so when a new test or finidat file are added and one of the subkeys is misspelled you will get an error and tester will die.

Specific notes

Contributors other than yourself, if any:

@ekluzek

Resolves #2673

@mvdebolskiy mvdebolskiy added support user or developer needs help tag: simple bfb testing additions or changes to tests labels Aug 8, 2024
@mvdebolskiy
Copy link
Contributor Author

You can test this by misspelling a subkey for one of the existing ones.

@samsrabin samsrabin added simple bfb bit-for-bit and removed simple bfb labels Aug 8, 2024
@mvdebolskiy
Copy link
Contributor Author

Fixes #2673

@samsrabin samsrabin assigned samsrabin and ekluzek and unassigned samsrabin Aug 22, 2024
@mvdebolskiy mvdebolskiy changed the base branch from master to b4b-dev August 22, 2024 15:58
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I'm going to bring this in as it will help with other namelist work we will be working on.

@ekluzek ekluzek merged commit 98e42fb into ESCOMP:b4b-dev Oct 1, 2024
2 checks passed
@ekluzek ekluzek deleted the fix-namelist-tester branch October 1, 2024 20:45
@samsrabin samsrabin mentioned this pull request Oct 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit support user or developer needs help testing additions or changes to tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants