Addition of clm6_0 physics option #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke namelists it needs clm5_1 and clm6_0, and others like most of the testing the Clm60 just replace Clm51
ekluzek
added
the
enhancement
slevis-lmwg
requested changes
Mar 11, 2024
There was a problem hiding this comment.
@ekluzek I could approve this after a couple of corrections that I think are necessary; however, I suggest that we also meet for 30 minutes or so to go over other thoughts/questions/suggestions.
cime_config/testdefs/testmods_dirs/clm/clm60cam6LndTuningMode/shell_commands
Outdated
Show resolved
Hide resolved
…of an old dataset that is no longer used. It was no longer used in mksurfdata_map either but it was in place. Hence why it was kept here. So I've removed it now
…to read now and makes it shorter. Update the build-namelist unit tester and show that the clm4_5, clm5_0, and clm5_1 tests are all identical
slevis-lmwg
approved these changes
Mar 18, 2024
|
My earlier comment was in the wrong PR, so moving it to the right one and deleting it here. |
Update to ctsm5.1.dev174 Update to newer tag. Which also includes an externals update which broke the build/run of mksurfdata_esmf. As a result I added some additional unit-testing in order to detect this sort of thing sooner. Conflicts: bld/namelist_files/namelist_defaults_ctsm.xml bld/unit_testers/build-namelist_test.pl
Merge up to ctsm5.1.dev175 Merge up to ctsm5.1.dev175 and do standard aux_clm testing. Conflicts: bld/unit_testers/build-namelist_test.pl
ekluzek
commented
Apr 1, 2024
ekluzek
commented
Apr 2, 2024
slevis-lmwg
requested changes
Apr 2, 2024
There was a problem hiding this comment.
@ekluzek thank you for asking. Here are two comments on the README modifications.
From suggestion by @slevis-lmwg in review. Co-authored-by: Samuel Levis <slevis@ucar.edu>
Use line return in place of ; in shell examples. Add some links
ekluzek
commented
Apr 3, 2024
Remove nvhpc test from ctsm_sci since not passing. Keep the one expected fail for nvhpc. Change the Expected fails for Clm51 to Clm60. Remove the mpasa3p75 test as it's experimental and requires a huge number of processors.
…jobscript so the test case is completely self-contained
Move the ne30 tests that were in the cesm3_dev test list to the aux_clm. And remove the cesm3_dev testlist.
…and aux_cime_baselines tests are run in aux_clm
…t so can make a ctsm5.2.0 tag
slevis-lmwg
reviewed
Apr 9, 2024
There was a problem hiding this comment.
@ekluzek thank you for the detailed effort that you put into this work!
This was referenced Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add clm6_0 as an option for CLM_PHYSICS_VERSION. Copy clm5_1 namelist settings
to clm6_0. Move clm5_1 compsets and testing to clm6_0 with just a couple for testing
until CESM and CAM move from clm5_1 to clm6_0.
This will be the last or at least one of the last tags in the ctsm5.2.mksurfdata branch
series, so will also make sure the mksurfdata_esmf README files and such are in good
shape and usable, as well as starting the ChangeLog/ChangeSum for the final ctsm5.2.0
tag.
We also need to get the python tools testing clean. Currently lint doesn't pass, and there is
a failing python sys test.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #2378
Fixes #2418
Fixes #1719
Are answers expected to change (and if so in what way)? no
Any User Interface Changes (namelist or namelist defaults changes)?
Addition of clm6_0 physics option and compsets
Removal of most clm5_1 tests and compsets (only a few left until CAM and CESM remove it's use)
Testing performed, if any: will do standard testing when finished testing all test lists