Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pftmask from history and PFTDATA_MASK from fsurdat files #1866

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

slevis-lmwg
Copy link
Contributor

Description of changes

Simple mods to reduce confusion as explained in #1703

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed:
Fixes #1703

Are answers expected to change (and if so in what way)?
No but pftmask and PFTDATA_MASK will not appear in history and fsurdat files, respectively.

Testing:
Confirmed that fsurdat files do not include PFTDATA_MASK and have no other changes.

@slevis-lmwg
Copy link
Contributor Author

@ekluzek this PR is ready for review. Let me know if you would like to discuss it in a meeting.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

@ekluzek ekluzek marked this pull request as ready for review October 8, 2022 20:57
@ekluzek ekluzek merged commit 981247f into ESCOMP:ctsm5.2.mksurfdata Oct 8, 2022
@ekluzek ekluzek deleted the rm_pftmask branch October 8, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce confusion about fsurdat vars LANDFRAC_PFT, PFTDATA_MASK vs. history vars landfrac, landmask, pftmask
2 participants