Enable the mksurfdata_map to generate landuse_timeseries for dynamic urban and lake #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In normalizencheck_landuse, still reduce crop and natveg proportionally when urban exist.
changed a txt file name
Add PCT_NATVEG for testing purpose
|
(Copying this comment from #1579 (comment) )
|
|
Next steps (moving relevant pieces from discussion in #1579 to here):
|
slevis-lmwg
added a commit
that referenced
this pull request
Mar 21, 2022
- The code builds and a non-transient case completes: mpiexec_mpt -p "%g:" -np 288 ./src/mksurfdata < surfdata_1.9x2.5_hist_78pfts_CMIP6_1850_c220316.namelist - Transient case gives error: mpiexec_mpt -p "%g:" -np 288 ./src/mksurfdata < surfdata_1.9x2.5_hist_78pfts_CMIP6_1850-1899_c220316.namelist mksrfdata error: year for urban not equal to year for PFT files ...but I don't, yet, see a mistake in my implementation: from mksurfdata_map/src/mksurfdat.F90 lines 1117-1130 to mksurfdata_esmf/src/mksurfdat.F90 lines 883-908
samsrabin
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note about this PR
This PR is a continuation of #1579 (from @keerzhang1). I approved that PR in terms of the work needed from @keerzhang1, but there is still some work needed on our end, primarily in the perl code, before it can be completely merged. I have moved the branch to the ESCOMP repository so that further work can happen here, and so that @olyson can open a follow-up PR into this branch. (See also #1579 (comment))
The following description is copied from #1579
Description of changes
This update includes code changes that enable the mksurfdata_map to generate landuse_timeseries with transient urban variables (PCT_URBAN and HASURBAN).
Update (2021-12-21): The changes in #1073 was combined with this PR. Now the code changes enable the mksurfdata_map to generate landuse_timeseries with dynamic urban and lake variables (PCT_URBAN, PCT_LAKE, PCT_URBAN_MAX, and PCT_LAKE_MAX)
Specific notes
For now, the changes in the mksurfdata.pl are hardcoded to simply generate a landuse_timeseries*. txt file containing urban raw data locations that I specified.
Contributors other than yourself, if any: @keerzhang1 @olyson @fang-bowen @Face2sea
CTSM Issues Fixed (include github issue #): #1445
Are answers expected to change (and if so in what way)?
The surface datasets will be different.
Any User Interface Changes (namelist or namelist defaults changes)?
No.
Testing performed, if any: