Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check ozone stress and fates compatibility #618

Open
rgknox opened this issue Jan 17, 2019 · 1 comment
Open

check ozone stress and fates compatibility #618

rgknox opened this issue Jan 17, 2019 · 1 comment
Labels
enhancement new capability or improved behavior of existing capability

Comments

@rgknox
Copy link
Collaborator

rgknox commented Jan 17, 2019

The ozone stress calculations seem to be using patch/pft level variables that are likely not calculated when FATES is running. Compatibility either needs to be enabled/verified, or a proper bypass and incompatibility specified.

https://github.com/ESCOMP/ctsm/blob/master/src/biogeophys/OzoneMod.F90#L311
@billsacks
Copy link
Member

Here's a permalink to the code that @rgknox is referring to (@rgknox - your link won't make sense once master is updated so that the commented-out fates references are gone, which I plan to do soon):

https://github.com/ESCOMP/ctsm/blob/aedda97e50407a4580a4ef2033fd447176f56940/src/biogeophys/OzoneMod.F90#L364-L395

billsacks added a commit to billsacks/ctsm that referenced this issue Jan 18, 2019
@billsacks
Remove FATES-related commented-out code in OzoneMod
6e58f35 
This has been moved to ESCOMP#618
billsacks added a commit to billsacks/ctsm that referenced this issue Jan 18, 2019
@billsacks
Remove FATES-related commented-out code in OzoneMod
8011904 
This has been moved to ESCOMP#618
billsacks added a commit that referenced this issue Jan 23, 2019
@billsacks
Merge branch 'minor_fixes'
f1c4d8f 
History fields for vertically-resolved sums of soil C/N, and minor fixes

Main change is from Keith Oleson: Add history fields for
vertically-resolved sums of SOIL1C, SOIL2C, and SOIL3C for C12, C13,
C14, and similarly for N. New fields are SOILC_vr, C13_SOILC_vr, and
C14_SOILC_vr, and SOILN_vr. For runs that use the output_bgc usermods,
including cmip6 runs, we no longer output 'SOIL1C_vr', 'SOIL1N_vr',
'SOIL2C_vr', 'SOIL2N_vr', 'SOIL3C_vr', 'SOIL3N_vr'; instead we output
'SOILC_vr', 'SOILN_vr', and similarly for C isotopes.

Also minor fixes:
- Output cpl hist files in SSP test (resolves #61)
- Remove FATES-related commented-out code in OzoneMod (this has been
  moved to #618)
- Minor tweak to run_sys_tests
billsacks added a commit that referenced this issue Jan 23, 2019
@billsacks
Merge branch 'minor_fixes_release' into release-clm5.0
f65c9c4 
History fields for vertically-resolved sums of soil C/N, and minor fixes

Main change is from Keith Oleson: Add history fields for
vertically-resolved sums of SOIL1C, SOIL2C, and SOIL3C for C12, C13,
C14, and similarly for N. New fields are SOILC_vr, C13_SOILC_vr, and
C14_SOILC_vr, and SOILN_vr. For runs that use the output_bgc usermods,
including cmip6 runs, we no longer output 'SOIL1C_vr', 'SOIL1N_vr',
'SOIL2C_vr', 'SOIL2N_vr', 'SOIL3C_vr', 'SOIL3N_vr'; instead we output
'SOILC_vr', 'SOILN_vr', and similarly for C isotopes.

Also minor fixes:
- Output cpl hist files in SSP test (resolves #61)
- Remove FATES-related commented-out code in OzoneMod (this has been
  moved to #618)
- Minor tweak to run_sys_tests
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this issue Jan 29, 2019
@slevis-lmwg
Merge tag 'ctsm1.0.dev025' into nwp_collapse_pfts
cd16b38 
History fields for vertically-resolved sums of soil C/N, and minor fixes

Main change is from Keith Oleson: Add history fields for
vertically-resolved sums of SOIL1C, SOIL2C, and SOIL3C for C12, C13,
C14, and similarly for N. New fields are SOILC_vr, C13_SOILC_vr, and
C14_SOILC_vr, and SOILN_vr. For runs that use the output_bgc usermods,
including cmip6 runs, we no longer output 'SOIL1C_vr', 'SOIL1N_vr',
'SOIL2C_vr', 'SOIL2N_vr', 'SOIL3C_vr', 'SOIL3N_vr'; instead we output
'SOILC_vr', 'SOILN_vr', and similarly for C isotopes.

Also minor fixes:
- Output cpl hist files in SSP test (resolves ESCOMP#61)
- Remove FATES-related commented-out code in OzoneMod (this has been
  moved to ESCOMP#618)
- Minor tweak to run_sys_tests
@billsacks billsacks added enhancement new capability or improved behavior of existing capability and removed type: enhance - science labels May 24, 2019
@wwieder wwieder mentioned this issue Apr 6, 2021
Closed
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@billsacks
Remove FATES-related commented-out code in OzoneMod
1649b05 
This has been moved to ESCOMP#618
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@billsacks
Merge branch 'minor_fixes_release' into release-clm5.0
6893247 
History fields for vertically-resolved sums of soil C/N, and minor fixes

Main change is from Keith Oleson: Add history fields for
vertically-resolved sums of SOIL1C, SOIL2C, and SOIL3C for C12, C13,
C14, and similarly for N. New fields are SOILC_vr, C13_SOILC_vr, and
C14_SOILC_vr, and SOILN_vr. For runs that use the output_bgc usermods,
including cmip6 runs, we no longer output 'SOIL1C_vr', 'SOIL1N_vr',
'SOIL2C_vr', 'SOIL2N_vr', 'SOIL3C_vr', 'SOIL3N_vr'; instead we output
'SOILC_vr', 'SOILN_vr', and similarly for C isotopes.

Also minor fixes:
- Output cpl hist files in SSP test (resolves ESCOMP#61)
- Remove FATES-related commented-out code in OzoneMod (this has been
  moved to ESCOMP#618)
- Minor tweak to run_sys_tests
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 5, 2024
@billsacks
Remove FATES-related commented-out code in OzoneMod
0ab96b1 
This has been moved to ESCOMP#618
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 5, 2024
@billsacks
Merge branch 'minor_fixes_release' into release-clm5.0
80abc8d 
History fields for vertically-resolved sums of soil C/N, and minor fixes

Main change is from Keith Oleson: Add history fields for
vertically-resolved sums of SOIL1C, SOIL2C, and SOIL3C for C12, C13,
C14, and similarly for N. New fields are SOILC_vr, C13_SOILC_vr, and
C14_SOILC_vr, and SOILN_vr. For runs that use the output_bgc usermods,
including cmip6 runs, we no longer output 'SOIL1C_vr', 'SOIL1N_vr',
'SOIL2C_vr', 'SOIL2N_vr', 'SOIL3C_vr', 'SOIL3N_vr'; instead we output
'SOILC_vr', 'SOILN_vr', and similarly for C isotopes.

Also minor fixes:
- Output cpl hist files in SSP test (resolves ESCOMP#61)
- Remove FATES-related commented-out code in OzoneMod (this has been
  moved to ESCOMP#618)
- Minor tweak to run_sys_tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgknox @billsacks