Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow namelist defaults to apply for phys versions greater than or less than a given version #454

Open
billsacks opened this issue Jul 27, 2018 · 2 comments
Open

Allow namelist defaults to apply for phys versions greater than or less than a given version #454

billsacks opened this issue Jul 27, 2018 · 2 comments
Labels
blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability

Comments

@billsacks
Copy link
Member

As we support more and more versions, I feel like we'll (at least eventually) want the ability for the namelist defaults xml file to allow us to say things like: "For CLM versions <= clm5.0, use foo = 3; for CLM versions > clm5.0, use foo = 7". Currently, we need to explicitly list the defaults for every phys version, which is going to be hard to maintain and error-prone long-term.

I feel like it will be useful for this purpose to separate the phys version into two pieces: a name and a version number. The name will be something like "clm" or "nwp" (the former for the "climate" version of CTSM, the later for the numerical weather prediction version). The version will be numeric.

I'm then imagining we could have a namelist default entry that looks like:

<foo phys="clm" version="<= 5.0">3</foo>
<foo phys="clm" version="> 5.0">7</foo>

or

<foo phys="clm" version_le="5.0">3</foo>
<foo phys="clm" version_gt="5.0">7</foo>
@billsacks billsacks added the enhancement new capability or improved behavior of existing capability label Jul 27, 2018
@billsacks billsacks mentioned this issue Jul 27, 2018
Closed
billsacks added a commit to billsacks/ctsm that referenced this issue Jan 4, 2019
@billsacks
Remove numeric representation of physv
6757549 
Eventually we'll want to have the capability for a numeric
representation of the physics version, for clm, nwp and other physics
versions (e.g., see ESCOMP#454). However,
until this is supported robustly (which will probably wait until the
python implementation), we don't want to risk having numeric comparisons
creep back into CLMBuildNamelist, because they will likely do the wrong
thing (e.g., if you ask for a version >= 5.0, this will do the wrong
thing with an nwp physics option). So to avoid incorrect usage, I'm
temporarily removing this capability entirely.
@billsacks billsacks mentioned this issue Apr 10, 2019
Closed
mariuslam pushed a commit to NordicESMhub/ctsm that referenced this issue Aug 26, 2019
@rgknox
Merge pull request ESCOMP#454 from ckoven/secondary_forest
c7fa7c2 
Track secondary forest area to keep primary and secondary patches distinct
@billsacks billsacks added the blocked: dependency Wait to work on this until dependency is resolved label Jan 14, 2020
@billsacks
Copy link
Member Author

Blocked by #585

@billsacks billsacks mentioned this issue Jan 14, 2020
Open
@ekluzek
Copy link
Collaborator

ekluzek commented Apr 30, 2024

Another thing that ParamGen could solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability
Projects
CTSM: Rewrite build-namelist in python
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billsacks @ekluzek