Skip to content

Incorrect value being set for FATES electron transport namelist option #3062

Open
@glemieux

Description

@glemieux

Brief summary of bug

While testing NGEET/fates#1350, all fates testmods fail RUN due to being passed an unexpected integer value for fates_electron_transport_model.

General bug information

CTSM version you are using: ctsm5.3.036

Does this bug cause significantly incorrect results in the model's science? [Yes / No] No

Configurations affected:

Details of bug

The incorrect integer variable is being set when trying to pass the electron transport model option. It should be setting pass_electron_transport_model instead of pass_radiation_model:

if (trim(fates_electron_transport_model) == 'FvCB1980') then
pass_radiation_model = 1
else if (trim(fates_electron_transport_model) == 'JohnsonBerry2021') then
pass_radiation_model = 2
end if

Note that the variable being passed via set_fates_ctrlparms is correct.

Important details of your setup / configuration so we can reproduce the bug

This was discovered during testing of NGEET/fates#1350.

Important output or errors that show the problem

lnd.log

4100  Successfully initialized the land model
4101  begin initial run at:
4102     nstep=            1  year=         2000  month=            1  day=
4103            1  seconds=         1800
4104     
4105 ************************************************************
4106     
4107  --WARNING-- skipping CN balance check for first timesteps after startup or data
4108   assimilation
4109  error, incorrect leaf electron transport model specified
4110  ENDRUN: 
4111  ERROR in LeafBiophysicsMod.F90 at line 462

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions