Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate line of code in CNVegCarbonStateType.F90 #2107

Closed
olyson opened this issue Aug 15, 2023 · 1 comment · Fixed by #1861
Closed

Duplicate line of code in CNVegCarbonStateType.F90 #2107

olyson opened this issue Aug 15, 2023 · 1 comment · Fixed by #1861
Assignees
@slevis-lmwg
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)

Comments

@olyson
Copy link
Contributor

olyson commented Aug 15, 2023

Brief summary of bug

There is a duplicate line of code in CNVegCarbonStateType.F90

General bug information

CTSM version you are using: ctsm5.1.dev133

Does this bug cause significantly incorrect results in the model's science? No

Details of bug

Line 1640 is duplicated, i.e.,

1634 if (flag=='read' .and. .not. readvar) then
1635 if ( masterproc ) write(iulog,*) 'initializing this%leafc_storage with atmospheric c13 value'
1636 do i = bounds%begp,bounds%endp
1637 if (pftcon%c3psn(patch%itype(i)) == 1._r8) then
1638 this%leafc_storage_patch(i) = c12_cnveg_carbonstate_inst%leafc_storage_patch(i) * c3_r2
1639 else
1640 this%leafc_storage_patch(i) = c12_cnveg_carbonstate_inst%leafc_storage_patch(i) * c4_r2
1641 this%leafc_storage_patch(i) = c12_cnveg_carbonstate_inst%leafc_storage_patch(i) * c4_r2
1642 endif
1643 end do
1644 end if
@ekluzek ekluzek added code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Aug 15, 2023
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 19, 2023
@wwieder
Copy link
Contributor

wwieder commented Oct 19, 2023

Will address in #1861

@slevis-lmwg slevis-lmwg mentioned this issue Oct 19, 2023
Merged
slevis-lmwg added a commit to cenlinhe/CTSM that referenced this issue Oct 19, 2023
@slevis-lmwg
Removing duplicate lines of code ESCOMP#2129 ESCOMP#2107
1890865
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slevis-lmwg slevis-lmwg

Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SNICAR snow albedo scheme updates cenlinhe/CTSM
5 participants
@wwieder @samsrabin @ekluzek @olyson @slevis-lmwg