Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMICS related parameters missing name and units in paramfile #1845

Closed
ecaas opened this issue Sep 6, 2022 · 4 comments · Fixed by #2258
Closed

MIMICS related parameters missing name and units in paramfile #1845

ecaas opened this issue Sep 6, 2022 · 4 comments · Fixed by #2258
Assignees
Labels
documentation additions or edits to user-facing documentation

Comments

@ecaas
Copy link

ecaas commented Sep 6, 2022

Currently, most MIMICS parameters in file "ctsm51_params.c211112.nc" are missing both long names and units.

Another minor thing, somewhat related; the comment in the line below refers to Wieder et al 2015 in which the parameters are actually multiplied (Eq. 2), not divided. Referring to the testbed version instead would reduce confusion.

real(r8), private :: kmod_l1_m1 ! kmod = ak / kmod from Wieder et al 2015

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 15, 2022
@billsacks billsacks added documentation additions or edits to user-facing documentation and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Sep 22, 2022
@slevis-lmwg
Copy link
Contributor

Something else that I came across that may need updating in restart files for use with MIMICS:
decomp_cascade_state

@slevis-lmwg slevis-lmwg changed the title MIMICS related parameters is missing name and units in paramfile MIMICS related parameters missing name and units in paramfile Sep 6, 2023
@slevis-lmwg

This comment was marked as outdated.

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Sep 8, 2023

Add this reference for mimics_densdep:
Georgiou, K.,et al. Nat Commun (2017). https://doi.org/10.1038/s41467-017-01116-z
and a comment in the MIMICS code that mimics_densdep = 1 so as to have no effect currently.

Make fchem_p1= fchem_p3 * fchem_p1 in the params file. See /glade/u/home/slevis/paramfiles/ctsm51_params.RMfchem.c230909.nc.
Make length fchem = 2 from 4 in paramfile and code. Change the code accordingly.
@slevis-lmwg confirmed that this changes answers from baseline for mimics cases (roundoff due to changed order of operations).

See https://docs.google.com/spreadsheets/d/1micmd__4E58YA9q414KjPPvTcIimZpCO42Pe3KfK7ms/edit#gid=0
for mimics param long names and units.

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Sep 8, 2023

Reminder that we want to include the above param file mods in #2040
All changes are summarized in the above post.

Update: This issue appears in a card with non-answer-changing params file changes and in a card with answer-changing params file changes.

@slevis-lmwg slevis-lmwg self-assigned this Nov 14, 2023
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this issue Nov 17, 2023
samsrabin added a commit to samsrabin/CTSM that referenced this issue Nov 27, 2023
New params files for Meier roughness, MIMICS, SNICAR, and with changes to leafcn and k*_nonmyc

1) Start using existing new params file for Meier roughness:
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/paramdata/ctsm51_params.RMz0.c231011.nc
and include bug-fix ESCOMP#2219
2) Update forcing heights per ESCOMP#2071.
3) Update params file for MIMICS per ESCOMP#1845.
4) Make leafcn for pfts 15 and 16 the same per ESCOMP#2184.
5) Switch the values of params kc_nonmyc and kn_nonmyc per ESCOMP#2120.
6) Move SNICAR parameters to params file per ESCOMP#2247.

Changes answers. Details in PR ESCOMP#2258 and in the ChangeLog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation additions or edits to user-facing documentation
Projects
None yet
4 participants