Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In perl code replace glob with bsd_glob #1550

Closed
billsacks opened this issue Nov 15, 2021 · 1 comment · Fixed by #1467
Closed

In perl code replace glob with bsd_glob #1550

billsacks opened this issue Nov 15, 2021 · 1 comment · Fixed by #1467
Assignees
@ekluzek
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability

Comments

@billsacks
Copy link
Member

Reported by @jedwards4b (#585 (comment))

errput: File::Glob::glob() will disappear in perl 5.30. Use File::Glob::bsd_glob() instead. at /work/02503/edwardsj/cesm2_x.ihesp/components/clm/bld/CLMBuildNamelist.pm line 4193.

I'm not sure if we can simply replace glob with bsd_glob or if the interface is different. We should also confirm that bsd_glob is available in older perl versions so that this will work for both older & newer versions.
@billsacks billsacks added enhancement new capability or improved behavior of existing capability tag: simple bfb labels Nov 15, 2021
@ekluzek ekluzek self-assigned this Dec 7, 2021
@ekluzek
Copy link
Collaborator

ekluzek commented Dec 7, 2021

It looks like this was already done by @billsacks in

294f9e7

The only thing I don't see it done for is in the mksurfdata_map unit test...

tools/mkprocdata_map/src/Mkdepends

It also looks like there are issues in cime under

utils/perl5lib

This was referenced Dec 7, 2021
Open
Closed
ekluzek added a commit to jedwards4b/ctsm that referenced this issue Dec 9, 2021
@ekluzek
Switch out glob for bsd_glog because it's being removed in newer perl…
4c1b355 
… versions this fixes ESCOMP#1550
@ekluzek ekluzek mentioned this issue Dec 9, 2021
Merged
@ekluzek ekluzek changed the title In perl build-namelist, replace glob with bsd_glob In perl MkDepends in mksurfdata, replace glob with bsd_glob Dec 13, 2021
@ekluzek ekluzek changed the title In perl MkDepends in mksurfdata, replace glob with bsd_glob In perl code replace glob with bsd_glob Dec 13, 2021
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekluzek ekluzek

Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve ui for neon script jedwards4b/ctsm
3 participants
@billsacks @samsrabin @ekluzek