FATES doesn't work with MEGAN for normal FATES competitive modes

[ekluzek]

Erik Kluzek < erik > - 2015-05-11 16:17:41 -0600
Bugzilla Id: 2176
Bugzilla CC: rfisher, sacks,

MEGAN at least functioned before clm4_5_1_r106, but in clm4_5_1_r106, MEGAN fails here...
if ( (cisun_in .eq. cisun_in) .and. (cisha_in .eq. cisha_in) .and. (forc_pbot_in > 0._r8) .and. (fsun_in > 0._r8) ) then
ci = ( fsun_in*cisun_in + (1._r8-fsun_in)*cisha_in )/forc_pbot_in * 1.e6_r8

 gamma_ci = Ismax - ( (Ismax*ci**h)/(Cstar**h+ci**h) )

cisun_in and cisha_in are still set to missing value (-999.) and hence the calculation fails.

Definition of done: FATES works with MEGAN for standard FATES mode with competition

[ekluzek]

Erik Kluzek < erik > - 2015-05-12 15:19:59 -0600

These are the two tests that failed.

ERS_D_Mmpi-serial_Ld5.1x1_brazil.ICLM45ED.yellowstone_intel.clm-edTest
SMS_Ld5.f19_g16.ICLM45ED.yellowstone_gnu.clm-edTest

There are some tests that actually passed even with the issue. So it must be partially dependent on the compiler.

But, I'm having build-namelist to make sure MEGAN is off if ED is on, and the ED tests will now be with MEGAN off. And there was an issue in clm.buildnml that didn't allow MEGAN to be off, so I fixed that as well.

[ekluzek]

Erik Kluzek < erik > - 2015-05-12 16:12:09 -0600

The SMS gnu test still fails with the following error...

   1: NetCDF: Numeric conversion not representable
   1: pio_support::pio_die:: myrank=          -1 : ERROR: pionfwrite_mod::write_nfdarray_double:         249 : NetCDF: Numeric conversion not representable
   1:Abort(1) on node 1 (rank 1 in comm 1140850688): application called MPI_Abort(MPI_COMM_WORLD, 1) - process 1

That is with MEGAN turned off.

[ekluzek]

Erik Kluzek < erik > - 2015-05-14 10:50:41 -0600

By turning off a bunch of history fields, I got it to run further. Then it stopped in RTM, so I turned RTM off...

Change user_nl_clm hist_fincl1 to...

hist_fincl1 = 'GPP','BTRAN','H2OSOI','LITTER_IN',
'FIRE_AREA','FIRE_INTENSITY','FIRE_TFC_ROS'
'FIRE_NESTEROV_INDEX',
'FIRE_ROS','DISPVEGC','AREA_TREES','AREA_PLANT'

And make a bunch of those fields inactive...

Index: ../../components/clm/src/ED/main/EDCLMLinkMod.F90
===================================================================
--- ../../components/clm/src/ED/main/EDCLMLinkMod.F90	(revision 70648)
+++ ../../components/clm/src/ED/main/EDCLMLinkMod.F90	(working copy)
@@ -221,19 +221,23 @@
 
     call hist_addfld2d (fname='PFTbiomass',  units='kgC/m2', type2d='levgrnd', &
          avgflag='A', long_name='total PFT level biomass', &
-         ptr_patch=this%PFTbiomass_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%PFTbiomass_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld2d (fname='PFTleafbiomass',  units='kgC/m2', type2d='levgrnd', &
          avgflag='A', long_name='total PFT level biomass', &
-         ptr_patch=this%PFTleafbiomass_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%PFTleafbiomass_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld2d (fname='PFTstorebiomass',  units='kgC/m2', type2d='levgrnd', &
          avgflag='A', long_name='total PFT level biomass', &
-         ptr_patch=this%PFTstorebiomass_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%PFTstorebiomass_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld2d (fname='PFTnindivs',  units='kgC/m2', type2d='levgrnd', &
          avgflag='A', long_name='total PFT level biomass', &
-         ptr_patch=this%PFTnindivs_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%PFTnindivs_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld1d (fname='FIRE_NESTEROV_INDEX', units='none',  &
          avgflag='A', long_name='nesterov_fire_danger index', &
@@ -249,7 +253,8 @@
 
     call hist_addfld1d (fname='FIRE_TFC_ROS', units='none',  &
          avgflag='A', long_name='total fuel consumed', &
-         ptr_patch=this%TFC_ROS_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%TFC_ROS_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive')
 
     call hist_addfld1d (fname='FIRE_INTENSITY', units='kJ/m/s',  &
          avgflag='A', long_name='spitfire fire intensity: kJ/m/s', &
@@ -261,27 +266,33 @@
 
     call hist_addfld1d (fname='SCORCH_HEIGHT', units='m',  &
          avgflag='A', long_name='spitfire fire area:m2', &
-         ptr_patch=this%scorch_height_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%scorch_height_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld1d (fname='fire_fuel_mef', units='m',  &
          avgflag='A', long_name='spitfire fuel moisture', &
-         ptr_patch=this%fire_fuel_mef_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%fire_fuel_mef_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld1d (fname='fire_fuel_bulkd', units='m',  &
          avgflag='A', long_name='spitfire fuel bulk density', &
-         ptr_patch=this%fire_fuel_bulkd_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%fire_fuel_bulkd_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld1d (fname='fire_fuel_eff_moist', units='m',  &
          avgflag='A', long_name='spitfire fuel moisture', &
-         ptr_patch=this%fire_fuel_eff_moist_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%fire_fuel_eff_moist_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld1d (fname='fire_fuel_sav', units='m',  &
          avgflag='A', long_name='spitfire fuel surface/volume ', &
-         ptr_patch=this%fire_fuel_sav_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%fire_fuel_sav_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive' )
 
     call hist_addfld1d (fname='TFC_ROS', units='m',  &
          avgflag='A', long_name='spitfire fuel surface/volume ', &
-         ptr_patch=this%TFC_ROS_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%TFC_ROS_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive')
 
     call hist_addfld1d (fname='SUM_FUEL', units=' KgC m-2 y-1',  &
          avgflag='A', long_name='Litter flux in leaves', &
@@ -293,7 +304,8 @@
 
     call hist_addfld1d (fname='LITTER_OUT', units=' KgC m-2 y-1',  &
          avgflag='A', long_name='Litter flux out leaves', &
-         ptr_patch=this%litter_out_patch, set_lake=0._r8, set_urb=0._r8)
+         ptr_patch=this%litter_out_patch, set_lake=0._r8, set_urb=0._r8, &
+         default='inactive')
 
     call hist_addfld1d (fname='SEED_BANK', units=' KgC m-2',  &
          avgflag='A', long_name='Total Seed Mass of all PFTs', &
@@ -347,7 +359,8 @@
     this%storvegc_patch(begp:endp) = spval
     call hist_addfld1d (fname='STORVEGC', units='gC/m^2', &
          avgflag='A', long_name='stored vegetation carbon, excluding cpool', &
-         ptr_patch=this%storvegc_patch)
+         ptr_patch=this%storvegc_patch, &
+         default='inactive')
 
     this%leafc_patch(begp:endp) = spval
     call hist_addfld1d (fname='LEAFC', units='gC/m^2', &
@@ -377,7 +390,7 @@
     this%npp_patch(begp:endp) = spval
     call hist_addfld1d (fname='NPP', units='gC/m^2/s', &
          avgflag='A', long_name='net primary production', &
-         ptr_patch=this%npp_patch)
+         ptr_patch=this%npp_patch, default='inactive')
 
   end subroutine InitHistory
 
Index: ../../components/clm/src/biogeophys/CanopyStateType.F90
===================================================================
--- ../../components/clm/src/biogeophys/CanopyStateType.F90	(revision 70648)
+++ ../../components/clm/src/biogeophys/CanopyStateType.F90	(working copy)
@@ -168,7 +168,7 @@
     this%tlai_patch(begp:endp) = spval
     call hist_addfld1d (fname='TLAI', units='none', &
          avgflag='A', long_name='total projected leaf area index', &
-         ptr_patch=this%tlai_patch)
+         ptr_patch=this%tlai_patch, default='inactive')
 
     this%tsai_patch(begp:endp) = spval
     call hist_addfld1d (fname='TSAI', units='none', &
Index: ../../components/clm/src/main/atm2lndType.F90
===================================================================
--- ../../components/clm/src/main/atm2lndType.F90	(revision 70648)
+++ ../../components/clm/src/main/atm2lndType.F90	(working copy)
@@ -255,7 +255,7 @@
     this%forc_wind_grc(begg:endg) = spval
     call hist_addfld1d (fname='WIND', units='m/s',  &
          avgflag='A', long_name='atmospheric wind velocity magnitude', &
-         ptr_lnd=this%forc_wind_grc)
+         ptr_lnd=this%forc_wind_grc, default='inactive')
     ! Rename of WIND for Urban intercomparision project
     call hist_addfld1d (fname='Wind', units='m/s',  &
          avgflag='A', long_name='atmospheric wind velocity magnitude', &

[ekluzek]

Erik Kluzek < erik > - 2015-05-14 13:28:37 -0600

In clm4_5_1_r106 when ED is on, MEGAN is NOT allowed to be on in the build-namelist.

[ekluzek]

I'm assigning this as a WONTFIX for now, and closing. This is a recognized problem that will take some effort to solve. Right now it doesn't seem needed, so we will wait until it does seem to be needed.

[billsacks]

Since there is discussion of moving to FATES as a default configuration, it seems like this will need to be worked on.

@ckoven @rosiealice @jkshuman @rgknox @glemieux

[jkshuman]

thanks for bringing this up @billsacks I will mention it in my "data" talk as a needed development