Some changes needed for the inversion_ismip6 branch for ice shelves #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass unphys_val down to interpolate_thermal_forcing_to_lsrf so can check if thermal_forcing is set, if it isn't set it to zero. change loops that start at nhalo to nhalo+1, so subscripts remain within arrays. Set indices for nearest neighbors so can ensure within array bounds. Add more checks that both kbot and ktop are set to signify a valid ocean point. If ktop == kbot set both to zero. If checks on kbot or ktop, make sure it's not zero before doing the check. Comment out the bug check that all points are filled. It writes the error for several points. But, doing this allows the simulation to complete.
…/cism into lipscomb/inversion_ismip6
… that is now passing, add in a verification that nhalo is large enough when basal melt is using thermal forcing
Contributor
|
Thanks, @ekluzek. I'll look at these changes after the LIWG meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the set of changes I needed to put in place, to get ice shelves working for a present day T compset.
Note, that I currently had to turn off an abort for the check
"Ocean data extrapolation error: did not fill level"
And I also added a check if kbot == ktop, that currently turns off the extrapolation for that point if triggered (and it's triggered very often).
I'm putting this in as a PR so it's easy to look at, and suggest changes to. I'm happy to make any changes suggested, or to have these changes dropped if different changes seem the right way to go.