Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

part of cam6_3_086: Fixes initialization for cam_dev #703

Merged
merged 4 commits into from
Dec 9, 2022
Merged

part of cam6_3_086: Fixes initialization for cam_dev #703

merged 4 commits into from
Dec 9, 2022

Conversation

cacraigucar
Copy link
Collaborator

Closes #701

@cacraigucar cacraigucar added the bug-fix This PR was created to fix a specific bug. label Nov 21, 2022
@cacraigucar cacraigucar added this to the CAM6.5 milestone Nov 21, 2022
@cacraigucar cacraigucar self-assigned this Nov 21, 2022
adamrher
adamrher approved these changes Nov 21, 2022
View reviewed changes
Copy link

@adamrher adamrher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Ben. Just has one clarification about these i variables we use in the pbuf_get_index calls, and whether they need to be initialized.

src/physics/rrtmg/cloud_rad_props.F90 Outdated Show resolved Hide resolved
bstephens82
bstephens82 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@bstephens82 bstephens82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I can't think of anything else to improve it now that we are initializing the indices.

adamrher added a commit to adamrher/CAM that referenced this pull request Nov 27, 2022
@adamrher
added cam_dev bug fix ESCOMP#703
f4f127c
@cacraigucar cacraigucar mentioned this pull request Nov 28, 2022
Merged
peverwhee
peverwhee approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

jtruesdal
jtruesdal approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@jtruesdal jtruesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me too.

@cacraigucar cacraigucar removed the request for review from nusbaume November 30, 2022 22:10
adamrher
adamrher approved these changes Dec 5, 2022
View reviewed changes
Copy link

@adamrher adamrher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. Note that there are no mods to radiation.F90 other than the removing of trailing zero's from the file.

@cacraigucar cacraigucar merged commit 8431a93 into ESCOMP:cam_development Dec 9, 2022
@cacraigucar cacraigucar changed the title Fixes initialization for cam_dev part of cam6_3_086: Fixes initialization for cam_dev Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gold2718 gold2718 gold2718 left review comments

@jtruesdal jtruesdal jtruesdal approved these changes

@peverwhee peverwhee peverwhee approved these changes

@adamrher adamrher adamrher approved these changes

@bstephens82 bstephens82 bstephens82 approved these changes

@nusbaume nusbaume Awaiting requested review from nusbaume

Assignees

@cacraigucar cacraigucar

Labels
bug-fix This PR was created to fix a specific bug.
Projects
CAM Development
Status: Tag
Milestone
CAM6.5
Development

Successfully merging this pull request may close these issues.
6 participants
@cacraigucar @gold2718 @jtruesdal @peverwhee @adamrher @bstephens82