-
Notifications
You must be signed in to change notification settings - Fork 166
Complete CCPPization of all gravity wave drag #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cam_development
Are you sure you want to change the base?
Conversation
…src/utils/cam_ccpp/pio_reader_sub.F90 These are slated to come in with a future tag by Courtney
…gw to the sima diagnostic directory
…obsolete diagnostics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jimmielin! I have some cleanup and error-checking requests, but hopefully nothing too problematic (and if you do run into any issues please let me know).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing in my suggestions @jimmielin! I just had a couple last requests and a question.
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @jimmielin! Everything looks good to me now.
Regression tests (izumi nag, gnu; derecho intel) pass as of 64_109; will merge up for another round of testing when the tags move further
Purpose of changes (include the issue number and title text for each relevant GitHub issue):
Describe any changes made to build system: Add gravity wave drag scheme subdirectory to atmos_phys.
Describe any changes made to the namelist:
List any changes to the defaults for the boundary datasets:
Describe any substantial timing or memory changes: N/A
Code reviewed by:
List all files eliminated:
List all files added and what they do:
List all existing files that have been modified, and describe the changes: