Skip to content

cam6_4_087: Update CAM testing. #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 22, 2025
Merged

Conversation

brian-eaton
Copy link
Collaborator

@brian-eaton brian-eaton commented Mar 21, 2025

Making progress on (but not resolving):

Issue #258 - Most converted CESM regression tests are CAM5 - may want to make most CAM7

  • simple model tests all use the 58 level LT vertical grid
  • refactor tests for FADIAB, FHS94, FKESSLER, FTJ16, FGRAYRAD

Issue #1280 - Convert all tests to the mt232 mask.

  • All updated tests use grids with mt232 masks.

@brian-eaton brian-eaton added the enhancement New feature or request label Mar 21, 2025
@brian-eaton brian-eaton self-assigned this Mar 21, 2025
@brian-eaton brian-eaton marked this pull request as ready for review April 18, 2025 18:09
@@ -1012,76 +1002,7 @@
<option name="wallclock">00:20:00</option>
</options>
</test>
<!-- 700 -->
<test compset="FADIAB" grid="ne5_ne5_mg37" name="ERI_D_Ln18" testmods="cam/outfrq3s_bwic">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the test case outfrq3s_bwic testing a feature which should continue to be tested?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outfrq3s_bwic testmods set analytic initial conditions to baroclinic wave. This is now the default for FADIAB and it's set in config_component.xml.

Comment on lines -1056 to -1066
<test compset="FADIAB" grid="ne5_ne5_mg37" name="PEM_D_Ln9" testmods="cam/outfrq3s">
<machines>
<machine name="izumi" compiler="nag" category="aux_cam"/>
</machines>
<options>
<option name="comment" >705 teq</option>
<option name="wallclock">00:30:00</option>
</options>
</test>
<!-- 706 tsm teq -->
<test compset="FADIAB" grid="ne5pg3_ne5pg3_mg37" name="PEM_D_Ln9" testmods="cam/outfrq3s">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we no longer need to run a PEM test (whatever that does)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PEM test runs two smoke tests at different PE counts. Since FADIAB doesn't run any physics this would only test that the dycore gets answers that are independent of task count. This functionality is verified in many other tests. The testing now includes just 1 test for FADIAB (per Peter and Jesse). It is using test ERC_D_Ln9_P1x1 and is the only test that runs the model serially.

Comment on lines -1329 to -1331
<!-- 730 -->
<test compset="FADIAB" grid="ne16_ne16_mg17" name="ERC_D_Ln9" testmods="cam/terminator">
<machines>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both terminator tests were eliminated. Don't we still need to test terminator chemistry?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FKESSLER is set up with terminator chemistry. This is done in config_component.xml.

Comment on lines -1397 to -1399
<test compset="FHS94" grid="mpasa480z32_mpasa480" name="ERC_D_Ln9" testmods="cam/outfrq3s_usecase">
<test compset="F2000dev" grid="ne30pg3_ne30pg3_mg17" name="MGP_D_Ln9" testmods="cam/outfrq3s">
<machines>
<machine name="derecho" compiler="intel" category="prealpha"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed several prealpha simple model tests. I always looked to them as being our first line of defense against externals breaking CAM jobs (CESM testing would uncover problems with externals before we bring those externals into CAM). Did you feel like this functionality is captured with other tests?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. Since the simple model tests use all stub components except for CAM, the testing only involves the CAM component and the infrastructure components. The infrastructure components are tested in our other tests. Simple models are basically CAM component only, so I think they should be tested in aux_cam.

Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the details. I am purposfully leaving these conversations unresolved to facilitate reviewing these comments if needed in the future.

@cacraigucar cacraigucar changed the title Update CAM testing. cam6_4_087: Update CAM testing. Apr 21, 2025
@brian-eaton brian-eaton merged commit e3bfb9a into ESCOMP:cam_development Apr 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

2 participants