Skip to content

Avoid fixing zero-cost singleton columns to infinite bounds in HPresolve::dualFixing - #3046

Merged
jajhall merged 7 commits into
ERGO-Code:fix-3046from
fwesselm:zeroCostCol
Jun 14, 2026
Merged

jajhall merged 7 commits into
ERGO-Code:fix-3046from
fwesselm:zeroCostCol

Conversation

@fwesselm

@fwesselm fwesselm commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator
  1. Avoid fixing zero-cost singleton columns to infinite bounds in HPresolve::dualFixing.
  2. Add logic to HPresolve::singletonCol handling zero-cost singletons.
  3. Ran 850+ MIPs - HiGHS' behavior was not affected.

@fwesselm
fwesselm requested a review from Opt-Mucca June 3, 2026 18:20
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.94%. Comparing base (dd33e6e) to head (2de9763).
⚠️ Report is 1 commits behind head on latest.

Files with missing lines Patch % Lines
highs/presolve/HPresolve.cpp 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3046      +/-   ##
==========================================
- Coverage   72.94%   72.94%   -0.01%     
==========================================
  Files         426      426              
  Lines      102185   102197      +12     
  Branches    16443    16452       +9     
==========================================
+ Hits        74540    74544       +4     
- Misses      27369    27377       +8     
  Partials      276      276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca

Copy link
Copy Markdown
Collaborator

@fwesselm It is a bit late and I'm quite tired, so may be missing something: Why do we want to do this? Aren't we now potentially missing some reductions that we were making before, e.g., an unbounded column with no locks on one-side that wouldn't appear as a singleton?

@jajhall

jajhall commented Jun 9, 2026

Copy link
Copy Markdown
Member

@Opt-Mucca : I'm guessing that fixing zero-cost singletons in this way is a special case (when there are no up/down locks) of #2962

Correct?

@Opt-Mucca

Copy link
Copy Markdown
Collaborator

@jajhall My confusion comes from columns that have multiple down (or up) locks, but zero in the other direction, and now aren't fixed to inf (or -inf). Wouldn't this fixing be useful and make the rows they feature in redundant after the fixing? (I have a feeling I may be missing something)

@Opt-Mucca

Copy link
Copy Markdown
Collaborator

@fwesselm After discussing with @jajhall : Was there any instance where this raised an error? It does look like it would require some conditional logic for the LP basis in postsolve.

@fwesselm

Copy link
Copy Markdown
Collaborator Author

@fwesselm After discussing with @jajhall : Was there any instance where this raised an error? It does look like it would require some conditional logic for the LP basis in postsolve.

@Opt-Mucca, yes, for a particular model (which I have to find again), dual fixing tries to fix a zero-cost column to an infinite bound. In this case, HPresolve::fixColToLower or HPresolve::fixColToUpper directly return Result::kDualInfeasible.

I agree that it may be possible to handle the case that a variable is fixed to +-kHighsInf, but postsolve does not currently (I think).

@jajhall

jajhall commented Jun 10, 2026

Copy link
Copy Markdown
Member

@Opt-Mucca, yes, for a particular model (which I have to find again), dual fixing tries to fix a zero-cost column to an infinite bound. In this case, HPresolve::fixColToLower or HPresolve::fixColToUpper directly return Result::kDualInfeasible.

I agree that it may be possible to handle the case that a variable is fixed to +-kHighsInf, but postsolve does not currently (I think).

I talked this through with @Opt-Mucca: no variable must ever be explicitly fixed to infinity.

The presolve reduction is achieved by removing the column with whatever bounds it has. The bounds on the corresponding rows are modified, possibly making a finite bound infinite if one/both of the column bounds are infinite.

Then, in postsolve, when the column is restored it is either

  • nonbasic at a finite bound if the corresponding constraints would then be satisfied
  • basic at a finite value so that all the corresponding constraints are satisfied - with at least one satisfied exactly. All the corresponding constraints would have been basic, so the binding constraint is made nonbasic at that bound, and the restored column becomes the basic variable.

The only safeguard that I see having to be added is that all the coefficients in the column must be sufficiently large, as they may become pivots when replacing the 1 of the slack variable in the binding row.

@jajhall
jajhall changed the base branch from latest to fix-3052 June 14, 2026 14:55
@jajhall
jajhall changed the base branch from fix-3052 to fix-3046 June 14, 2026 14:55
@jajhall

jajhall commented Jun 14, 2026

Copy link
Copy Markdown
Member

I need to test fwesselm:zeroCostCol and make sure there are no merge conflicts with zero-obj-singleton-double-sided-row

@jajhall
jajhall merged commit 2f19954 into ERGO-Code:fix-3046 Jun 14, 2026
349 of 351 checks passed
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
highs 1.15.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>The highlights of v1.15 are the first variant of the parallel MIP solver
and the addition of HiPO in Python.

## Code changes

Following [PR #2886](ERGO-Code/HiGHS#2886), our
prototype multithreaded MIP solver is available, refactoring
the worker/node-search logic of the branch-and-cut solver to run
across multiple threads. This is the first release of the parallel MIP
solver.

A fix to the parallel scheduler was merged in
[PR #3087](ERGO-Code/HiGHS#3087).

Following [PR #2994](ERGO-Code/HiGHS#2994),
HiPO can now be used to solve LPs and QPs from `highspy`, with
documentation added in
[PR #3024](ERGO-Code/HiGHS#3024) and
[PR #3060](ERGO-Code/HiGHS#3060). HiPO
performance was further improved by faster handling of free variables
([PR #3013](ERGO-Code/HiGHS#3013)) and faster
triangular solves
([PR #3014](ERGO-Code/HiGHS#3014)).

Prompted by [#2957](ERGO-Code/HiGHS#2957),
square Hessians that are only slightly asymmetric are now accepted by
`Highs::qFormatOk`, rather than being rejected outright
([PR #2965](ERGO-Code/HiGHS#2965),
[PR #2984](ERGO-Code/HiGHS#2984) and
[PR #3003](ERGO-Code/HiGHS#3003)). Identification
of non-convexity in the QP solvers was also improved, with extended
documentation added in
[PR #3056](ERGO-Code/HiGHS#3056), and a further
bug affecting some QPs was fixed in
[PR #3069](ERGO-Code/HiGHS#3069). QP hot start
was added in [PR #3089](ERGO-Code/HiGHS#3089).

Following [PR #2982](ERGO-Code/HiGHS#2982),
several bugs in the computation of an Irreducible Infeasible Subsystem
(IIS) via `Highs::getIis` were fixed.

Following [PR #3046](ERGO-Code/HiGHS#3046),
zero-cost singleton columns are no longer fixed to an infinite bound
during `HPresolve::dualFixing`, and the size of shifts applied during
reduced-cost fixing was reduced in
[PR #2986](ERGO-Code/HiGHS#2986). Strengthened
variable bounds found during presolve are now retained
([PR #3010](ERGO-Code/HiGHS#3010)), a bug in
the computation of the fractional value of a variable with finite
lower and upper bounds was fixed
([PR #3005](ERGO-Code/HiGHS#3005)), and the
handling of infeasibilities for semi-continuous and semi-integer
variables was corrected
([PR #3018](ERGO-Code/HiGHS#3018)).

Following [PR #3042](ERGO-Code/HiGHS#3042),
parallel simplex is no longer used when solving the LP relaxations
that arise within the MIP solver, since it isn't safe to do so when
the MIP solver is itself running in parallel.

Following [PR #2971](ERGO-Code/HiGHS#2971),
`highspy` now supports scalar division, and significant improvements
were made to `highspy`'s static typing in
[PR #2983](ERGO-Code/HiGHS#2983). Context
manager support was added to `highspy` in
[PR #3093](ERGO-Code/HiGHS#3093).

Following [PR #3039](ERGO-Code/HiGHS#3039),
`Highs::setBasis` and `Highs::setLogicalBasis` have been implemented,
and additional methods were added to the C# wrapper in
[PR #3041](ERGO-Code/HiGHS#3041).

Prompted by [#3044](ERGO-Code/HiGHS#3044),
a further bug was fixed in
[PR #3092](ERGO-Code/HiGHS#3092), and
[PR #3091](ERGO-Code/HiGHS#3091) corrects the
re-checking of an implied bound, fixing
[#3090](ERGO-Code/HiGHS#3090).

Following [PR #2981](ERGO-Code/HiGHS#2981),
C-heap memory leaks in solver state cleanup were fixed, and
[PR #3081](ERGO-Code/HiGHS#3081) fixes a bug
in column stuffing.

Following [PR #3016](ERGO-Code/HiGHS#3016),
`Highs::presolve()` now logs and returns failure appropriately when
called inconsistently with the state of the incumbent model.

Prompted by [#3007](ERGO-Code/HiGHS#3007), a
potential typo in `FactorHiGHSSolver::chooseNla()` was corrected, and
several other minor fixes were collected in
[PR #3017](ERGO-Code/HiGHS#3017) and
[PR #3004](ERGO-Code/HiGHS#3004) (the latter
for `HighsCliqueTable`).

Following [PR #3057](ERGO-Code/HiGHS#3057),
lines in HiGHS options files that contain only spaces are now ignored,
and the text of the first line containing an error is printed in the
resulting message.

## Build changes

The Python build has been updated and an additional python package is
available. The HiPO dependencies are linked via the optional
`highspy-extras`, e.g. Metis, for all platforms, and OpenBLAS, for
Windows and Linux. The `highspy-extras` package is automatically
consumed by `highspy` and does not need to be imported manually. Note,
that `highspy-extras` is distributed under the Apache 2.0 license, due
to the dependencies' licensing.

On Linux, `libblas` is no longer supported, in favour of OpenBLAS. MKL
support would be considered at a later stage.

Prompted by [#3000](ERGO-Code/HiGHS#3000),
[PR #3027](ERGO-Code/HiGHS#3027) fixes a
recent `alpine:edge` compilation issue.

Following [PR #3025](ERGO-Code/HiGHS#3025),
all remaining thread sanitizer data race warnings are cleared.

GPU support was added for local Python pip installs in
[PR #3071](ERGO-Code/HiGHS#3071) and the BLAS
library used by HiPO is now checked at runtime
([PR #3080](ERGO-Code/HiGHS#3080)).

The `cibuildwheel` workflow and `pyproject` configuration were updated
to `cibuildwheel` 4.0.0
([PR #3061](ERGO-Code/HiGHS#3061)), and the
NuGet publishing workflow now uses trusted publishing rather than an
API key
([PR #3062](ERGO-Code/HiGHS#3062),
following [PR #2959](ERGO-Code/HiGHS#2959)).

The macOS GitHub Actions build times were significantly improved in
[PR #3033](ERGO-Code/HiGHS#3033), and the C#
wrapper build was fixed to statically link the MSVC STL and correctly
install on win32
([PR #3070](ERGO-Code/HiGHS#3070)).

Following [PR #3001](ERGO-Code/HiGHS#3001),
the install location of the readme and license files was corrected,
and explicit `-fexceptions` copts were added to the Bazel config
([PR #3072](ERGO-Code/HiGHS#3072) and
[PR #3075](ERGO-Code/HiGHS#3075)).
</pre>
  <p>View the full release notes at <a href="https://github.com/ERGO-Code/HiGHS/releases/tag/v1.15.0">https://github.com/ERGO-Code/HiGHS/releases/tag/v1.15.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!12881
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
highs 1.15.1

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>Patch release v1.15.1 fixes:

Apache release binaries not including HiPO fixed in [PR #3112](ERGO-Code/HiGHS#3112).

Build for users with C++20 fixed in [PR #3114](ERGO-Code/HiGHS#3114).

OpenBLAS setup issue affecting performance fixed in [PR #3122](ERGO-Code/HiGHS#3122).

Values passed for string option values (except for file names) are
converted to lower case [PR #3108](ERGO-Code/HiGHS#3108).

---


The highlights of v1.15 are the first variant of the parallel MIP solver
and the addition of HiPO in Python.

## Code changes

Following [PR #2886](ERGO-Code/HiGHS#2886), our
prototype multithreaded MIP solver is available, refactoring
the worker/node-search logic of the branch-and-cut solver to run
across multiple threads. This is the first release of the parallel MIP
solver.

A fix to the parallel scheduler was merged in
[PR #3087](ERGO-Code/HiGHS#3087).

Following [PR #2994](ERGO-Code/HiGHS#2994),
HiPO can now be used to solve LPs and QPs from `highspy`, with
documentation added in
[PR #3024](ERGO-Code/HiGHS#3024) and
[PR #3060](ERGO-Code/HiGHS#3060). HiPO
performance was further improved by faster handling of free variables
([PR #3013](ERGO-Code/HiGHS#3013)) and faster
triangular solves
([PR #3014](ERGO-Code/HiGHS#3014)).

Prompted by [#2957](ERGO-Code/HiGHS#2957),
square Hessians that are only slightly asymmetric are now accepted by
`Highs::qFormatOk`, rather than being rejected outright
([PR #2965](ERGO-Code/HiGHS#2965),
[PR #2984](ERGO-Code/HiGHS#2984) and
[PR #3003](ERGO-Code/HiGHS#3003)). Identification
of non-convexity in the QP solvers was also improved, with extended
documentation added in
[PR #3056](ERGO-Code/HiGHS#3056), and a further
bug affecting some QPs was fixed in
[PR #3069](ERGO-Code/HiGHS#3069). QP hot start
was added in [PR #3089](ERGO-Code/HiGHS#3089).

Following [PR #2982](ERGO-Code/HiGHS#2982),
several bugs in the computation of an Irreducible Infeasible Subsystem
(IIS) via `Highs::getIis` were fixed.

Following [PR #3046](ERGO-Code/HiGHS#3046),
zero-cost singleton columns are no longer fixed to an infinite bound
during `HPresolve::dualFixing`, and the size of shifts applied during
reduced-cost fixing was reduced in
[PR #2986](ERGO-Code/HiGHS#2986). Strengthened
variable bounds found during presolve are now retained
([PR #3010](ERGO-Code/HiGHS#3010)), a bug in
the computation of the fractional value of a variable with finite
lower and upper bounds was fixed
([PR #3005](ERGO-Code/HiGHS#3005)), and the
handling of infeasibilities for semi-continuous and semi-integer
variables was corrected
([PR #3018](ERGO-Code/HiGHS#3018)).

Following [PR #3042](ERGO-Code/HiGHS#3042),
parallel simplex is no longer used when solving the LP relaxations
that arise within the MIP solver, since it isn't safe to do so when
the MIP solver is itself running in parallel.

Following [PR #2971](ERGO-Code/HiGHS#2971),
`highspy` now supports scalar division, and significant improvements
were made to `highspy`'s static typing in
[PR #2983](ERGO-Code/HiGHS#2983). Context
manager support was added to `highspy` in
[PR #3093](ERGO-Code/HiGHS#3093).

Following [PR #3039](ERGO-Code/HiGHS#3039),
`Highs::setBasis` and `Highs::setLogicalBasis` have been implemented,
and additional methods were added to the C# wrapper in
[PR #3041](ERGO-Code/HiGHS#3041).

Prompted by [#3044](ERGO-Code/HiGHS#3044),
a further bug was fixed in
[PR #3092](ERGO-Code/HiGHS#3092), and
[PR #3091](ERGO-Code/HiGHS#3091) corrects the
re-checking of an implied bound, fixing
[#3090](ERGO-Code/HiGHS#3090).

Following [PR #2981](ERGO-Code/HiGHS#2981),
C-heap memory leaks in solver state cleanup were fixed, and
[PR #3081](ERGO-Code/HiGHS#3081) fixes a bug
in column stuffing.

Following [PR #3016](ERGO-Code/HiGHS#3016),
`Highs::presolve()` now logs and returns failure appropriately when
called inconsistently with the state of the incumbent model.

Prompted by [#3007](ERGO-Code/HiGHS#3007), a
potential typo in `FactorHiGHSSolver::chooseNla()` was corrected, and
several other minor fixes were collected in
[PR #3017](ERGO-Code/HiGHS#3017) and
[PR #3004](ERGO-Code/HiGHS#3004) (the latter
for `HighsCliqueTable`).

Following [PR #3057](ERGO-Code/HiGHS#3057),
lines in HiGHS options files that contain only spaces are now ignored,
and the text of the first line containing an error is printed in the
resulting message.

## Build changes

The Python build has been updated and an additional python package is
available. The HiPO dependencies are linked via the optional
`highspy-extras`, e.g. Metis, for all platforms, and OpenBLAS, for
Windows and Linux. The `highspy-extras` package is automatically
consumed by `highspy` and does not need to be imported manually. Note,
that `highspy-extras` is distributed under the Apache 2.0 license, due
to the dependencies' licensing.

On Linux, `libblas` is no longer supported, in favour of OpenBLAS. MKL
support would be considered at a later stage.

Prompted by [#3000](ERGO-Code/HiGHS#3000),
[PR #3027](ERGO-Code/HiGHS#3027) fixes a
recent `alpine:edge` compilation issue.

Following [PR #3025](ERGO-Code/HiGHS#3025),
all remaining thread sanitizer data race warnings are cleared.

GPU support was added for local Python pip installs in
[PR #3071](ERGO-Code/HiGHS#3071) and the BLAS
library used by HiPO is now checked at runtime
([PR #3080](ERGO-Code/HiGHS#3080)).

The `cibuildwheel` workflow and `pyproject` configuration were updated
to `cibuildwheel` 4.0.0
([PR #3061](ERGO-Code/HiGHS#3061)), and the
NuGet publishing workflow now uses trusted publishing rather than an
API key
([PR #3062](ERGO-Code/HiGHS#3062),
following [PR #2959](ERGO-Code/HiGHS#2959)).

The macOS GitHub Actions build times were significantly improved in
[PR #3033](ERGO-Code/HiGHS#3033), and the C#
wrapper build was fixed to statically link the MSVC STL and correctly
install on win32
([PR #3070](ERGO-Code/HiGHS#3070)).

Following [PR #3001](ERGO-Code/HiGHS#3001),
the install location of the readme and license files was corrected,
and explicit `-fexceptions` copts were added to the Bazel config
([PR #3072](ERGO-Code/HiGHS#3072) and
[PR #3075](ERGO-Code/HiGHS#3075)).
</pre>
  <p>View the full release notes at <a href="https://github.com/ERGO-Code/HiGHS/releases/tag/v1.15.1">https://github.com/ERGO-Code/HiGHS/releases/tag/v1.15.1</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!13385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants