Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change npm bin usage into npm root #34 #36

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

kazkansouh
Copy link
Contributor

@kazkansouh kazkansouh commented Feb 22, 2023

I have rolled a simple fix for #34 to remove usage of npm bin and instead use npm root with .bin appended.

It looks like a simple change, I have run it locally but not tested it through github actions.

@kazkansouh
Copy link
Contributor Author

Ha, sorry just noticed there is #35. Please feel free to close this one 😉

@EPMatt EPMatt added the bump:patch Attach to PR to automatically bump patch version on merge label Mar 6, 2023
Copy link
Owner

@EPMatt EPMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! I prefer your approach rather than npx prettier in #35.
I'm merging this into main and publishing a new version for this action.

Thank you so much for your precious contribution! 🚀

@EPMatt EPMatt merged commit f29b719 into EPMatt:main Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

🚀 [bumpr] Bumped! New version:v1.1.1 Changes:v1.1.0...v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:patch Attach to PR to automatically bump patch version on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When run as a GitHub action on Ubuntu-latest, it fails to install/locate Prettier
2 participants