Fix virtual double press event for deconz #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The helper_last_controller_event "a" attribute is now forced to be written as a string, may break some integrations if a number or other type is expected.
Proposed change*
This change modifies all helper_last_controller_event updates to force the trigger_action to be written (and appropriately quoted) as a string.
There are a collection of regexes that test the contents of this json before parsing it and expect this value to be quoted. The existing implementation means that Virtual Double Press events were never generated in my use cases (deconz + ikea).
A better change might be to update the regexes to allow all types of variables or rework completely how that validation is applied, given that it is evidently fragile, but I settled on this approach as it seemed less impactful.
Checklist*
npm run format
before submitting my Pull Request.