first version commit #1
Conversation
…-java-android-sample-app into feature/finish_first_version
…-java-android-sample-app into feature/finish_first_version
…app into feature/finish_first_version
.idea/modules.xml
Outdated
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project version="4"> | |||
| <component name="ProjectModuleManager"> | |||
There was a problem hiding this comment.
you should probably add this to the .gitignore
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:orientation="vertical" | ||
| app:layout_constraintGuide_begin="395dp" /> |
There was a problem hiding this comment.
You may want to change these to percentages.
| android:id="@+id/edt_from_account" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:hint="Your account name" |
There was a problem hiding this comment.
We should use string resources for all the hard-coded strings.
| android:id="@+id/btn_check_balance" | ||
| android:layout_width="0dp" | ||
| android:layout_height="0dp" | ||
| android:text="CHECK" |
There was a problem hiding this comment.
Maybe we should say "CHECK BALANCE"....or something similar so they know what they are checking.
| app:layout_constraintStart_toStartOf="@+id/guideline4" | ||
| app:layout_constraintTop_toTopOf="@+id/guideline3" /> | ||
|
|
||
| <Button |
There was a problem hiding this comment.
Can we add a clear button to clear the logging display?
| app:layout_constraintStart_toStartOf="@+id/guideline" | ||
| app:layout_constraintTop_toBottomOf="@+id/edt_amount" /> | ||
|
|
||
| <EditText |
There was a problem hiding this comment.
The red and green don't seem to show up well on the gray background. Maybe we could experiment with some other color combos.
| */ | ||
| public static String getBackendErrorMessageFromResponse(@NonNull RPCResponseError error) { | ||
| StringBuilder detail = new StringBuilder(); | ||
| if (error.getError().getDetails().size() > 0) { |
There was a problem hiding this comment.
Use isEmpty() on collection.
| import one.block.eosiojavarpcprovider.implementations.EosioJavaRpcProviderImpl; | ||
| import one.block.eosiosoftkeysignatureprovider.SoftKeySignatureProviderImpl; | ||
| import one.block.eosiosoftkeysignatureprovider.error.ImportKeyError; | ||
|
|
There was a problem hiding this comment.
Let's add a comment for this class describing how we are using the libraries to create, sign, and send a transaction.
…IO/eosio-java-android-example-app into feature/finish_first_version
…-java-android-sample-app into feature/finish_first_version
No description provided.