Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

@b1bart
Copy link
Contributor

@b1bart b1bart commented Mar 5, 2020

In this PR:

  • basic plugin scaffolding for (2) plugins
    • a full system plugin _trace_api_plugin (temp name until the namespace is renamed)
    • a plugin that only serves the RPC api trace_api_rpc_plugin
    • only the full system will be linked in and available to nodeos
    • the rpc plugin is laying the ground work for an independent process and to force separation of internal logic
  • new header and test with what little testable logic fell out of configuration code
  • new concept for adding context to exceptions so that logging appropriately correlates messages to the code that produced them. There is an example of how this is wired in through the abi_data_handler so that the throwing code can provide the context to the injected log function.

Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending slack discussion.

@b1bart b1bart merged commit 8f33034 into feature/trace-api-plugin Mar 6, 2020
@b1bart b1bart deleted the feature/trace-api-plugin-boilerplate branch March 6, 2020 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants