Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Eosio build darwin: extensive validation#2879

Merged
heifner merged 2 commits intoEOSIO:masterfrom
pacificcode:eosio_build_darwin
May 9, 2018
Merged

Eosio build darwin: extensive validation#2879
heifner merged 2 commits intoEOSIO:masterfrom
pacificcode:eosio_build_darwin

Conversation

@pacificcode
Copy link
Contributor

Added check for cmake cache file in eos/ doc root.
Added extensive command validation error checking in darwin build.

@pacificcode pacificcode requested a review from heifner May 9, 2018 15:31
if [ -f "${PWD}/CMakeCache.txt" ]; then
printf "\\n\\tPlease remove file %s/CMakeCache.txt before building EOS.IO.\\n \\tExiting now.\\n\\n" "${PWD}"
exit 1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought people used the eosio_build.sh script to rebuild their eosio.io after an update. This prevents eosio_build.sh from working for an existing checkout with a previous build.

Copy link
Contributor Author

@pacificcode pacificcode May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is required in directory /path/to/eos/build/
If this file is located in the eos/ directory CMake will write its build files to the eos/ directory and not the build directory which will cause:
cd build/
make -j"${CPU_CORE}"
to error out i.e.
make: *** No targets specified and no makefile found. Stop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I build in source, but I guess build script does out of source. ok.

brew install --force pkgconfig
brew unlink pkgconfig && brew link --force pkgconfig
printf "\\n\\tChecking MongoDB C++ driver installation.\\n"
if [ ! -e "/usr/local/lib/libmongocxx-static.a" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the slim branch does not have a mongodb plugin and will likely not have one for June.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have $( git branch | grep * ) writing the current branch to stdout.
I can add a check in to install mongo when necessary. We need to define what that condition/branch is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be master branch soon.

@heifner heifner merged commit f17c28c into EOSIO:master May 9, 2018
@pacificcode pacificcode deleted the eosio_build_darwin branch May 10, 2018 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments