This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Move payment calculations from onblock to claimrewards #2805
Merged
spoonincode merged 5 commits intoslimfrom May 7, 2018
Merged
Move payment calculations from onblock to claimrewards #2805spoonincode merged 5 commits intoslimfrom
spoonincode merged 5 commits intoslimfrom
Conversation
bytemaster
suggested changes
May 6, 2018
|
|
||
| */ | ||
|
|
||
| INLINE_ACTION_SENDER(eosio::token, transfer)( N(eosio.token), {{N(eosio),N(active)}}, |
Contributor
There was a problem hiding this comment.
You should not transfer to self, "to savings" is just internal eosio.system state, no need for this last send.
Contributor
Author
There was a problem hiding this comment.
I deleted the transfer.
| const asset issue_amount = to_eos_bucket + to_savings + perblock_pay; | ||
|
|
||
| eosio_assert( rewards > asset(0, S(4,EOS)), "no rewards available to claim" ); | ||
| INLINE_ACTION_SENDER(eosio::token, issue)( N(eosio.token), {{N(eosio),N(active)}}, |
Contributor
There was a problem hiding this comment.
the memo is wrong here, some of these tokens are to savings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.