This repository was archived by the owner on Aug 2, 2022. It is now read-only.
EOSIO build darwin, home-brew installing boost 1.66#2683
Merged
spoonincode merged 3 commits intoEOSIO:masterfrom May 2, 2018
Merged
EOSIO build darwin, home-brew installing boost 1.66#2683spoonincode merged 3 commits intoEOSIO:masterfrom
spoonincode merged 3 commits intoEOSIO:masterfrom
Conversation
spoonincode
reviewed
May 1, 2018
scripts/eosio_build_darwin.sh
Outdated
| if ! brew install "https://raw.githubusercontent.com/Homebrew/homebrew-core/76a83d798d76aa43459ceb145b721ba4a16a54a6/Formula/boost.rb" | ||
| then | ||
| printf "\tUnable to install boost 1.66 libraries at this time. 0\n" | ||
| printf "\tExiting now. 0\n\n" |
Contributor
There was a problem hiding this comment.
Are these debug numbers being left in deliberately?
Contributor
Author
There was a problem hiding this comment.
@spoonincode Yes, but good catch. Only the first printf should have the 0. It's not an absolute requirement that these are left in there, but it does save time when users open issues.
added 2 commits
May 2, 2018 09:32
Merging master into eosio_build_darwin
spoonincode
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
darwin: added homebrew installing boost back into darwin build.