This repository was archived by the owner on Aug 2, 2022. It is now read-only.
fix txn_test_gen_plugin for stress test(DAWN-562)#1880
Merged
spoonincode merged 2 commits intoEOSIO:masterfrom Mar 29, 2018
Merged
fix txn_test_gen_plugin for stress test(DAWN-562)#1880spoonincode merged 2 commits intoEOSIO:masterfrom
spoonincode merged 2 commits intoEOSIO:masterfrom
Conversation
Contributor
|
Can you add a brief description of what this change does and how it does it? |
pmesnier
reviewed
Mar 27, 2018
| signed_transaction trx; | ||
| trx.actions.push_back(act_a_to_b); | ||
| trx.actions.emplace_back(action({}, config::system_account_name, "nonce", fc::raw::pack(nonce))); | ||
| //trx.context_free_actions.emplace_back(action({}, config::system_account_name, "nonce", fc::raw::pack(nonce))); |
Contributor
There was a problem hiding this comment.
Just delete the commented out code.
pmesnier
reviewed
Mar 27, 2018
| signed_transaction trx; | ||
| trx.actions.push_back(act_b_to_a); | ||
| trx.actions.emplace_back(action({}, config::system_account_name, "nonce", fc::raw::pack(nonce))); | ||
| //trx.context_free_actions.emplace_back(action({}, config::system_account_name, "nonce", fc::raw::pack(nonce))); |
Contributor
There was a problem hiding this comment.
And delete this commented out code as well
pmesnier
suggested changes
Mar 27, 2018
Contributor
pmesnier
left a comment
pmesnier
left a comment
There was a problem hiding this comment.
Please add a bit of description of why it was necessary to replacet he nonce action with a local salter. Also delete the commented code. le git manage revision history. :-)
Contributor
Author
|
the reason of removing the nonce action is that: the nonce action is now considered as context_free_action and it is no longer able to make the transaction unique. |
…880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880fix 1880
Contributor
Author
|
hi, another change is committed. |
spoonincode
approved these changes
Mar 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.