This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Third try at getting a clean commit pushed. #1614#1804
Merged
Conversation
Removed unused (and no longer appropriate) consecutive block production condition. Updated producer plugin required-participation option to take integer rather than bool. Removed check for low participation for now. We will need to implement a better metric for low participation eventually. I am keeping the required-participation option (even though it will effectively be ignored) because it will eventually be used with the new low participation metric.
heifner
reviewed
Mar 23, 2018
scripts/eosio-tn_roll.sh
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| %#!/bin/bash | |||
Contributor
There was a problem hiding this comment.
Looks like this slipped in.
…erge-664-try-3
Update dispatcher.hpp
Temporarily disable faulty low participation check changes until we come up with a better metric
heifner
approved these changes
Mar 23, 2018
Contributor
heifner
left a comment
heifner
left a comment
There was a problem hiding this comment.
This PR removes nodeos_run_remote.py test. A follow-on PR will add this test back in.
DAWN 672/ GitHub#1767 - Succinct error reports from ctest/jenkins
DAWN-694 - boot seq Unit tests
…erge-664-try-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to get my conflicts in try 2 resolved so I did a squash-merge into a new branch again.
Hopefully third time's a charm!