Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix small MUAD dataset URL #127

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

sofiia-chorna
Copy link
Contributor

It was noticed that the URL for the small MUAD dataset is no longer available in https://huggingface.co/fira7s/Muad2, I suggest the new address is the account of U2IS: https://huggingface.co/datasets/ENSTA-U2IS/miniMUAD. This change causes issues when attempting to download the dataset using the current implementation

In this PR, I updated the URL and added a small test to verify the accessibility of the small MUAD dataset.

Feel free to modify or expand upon this PR as needed 😊 Perhaps, actual new URL is different

Context

A screenshot of the error is attached below for your reference

Screenshot 2024-12-25 at 02 17 45

@alafage
Copy link
Contributor

alafage commented Dec 26, 2024

Hello @sofiia-chorna!

Thanks for the PR. We forgot to update the path when we changed the dataset's location.
The new URL is correct. I will merge your modifications with the dev branch!

@alafage alafage merged commit ec2d921 into ENSTA-U2IS-AI:dev Dec 26, 2024
1 check passed
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (63e9ece) to head (5e5635b).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #127   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files         143      143           
  Lines        7123     7123           
  Branches      908      908           
=======================================
  Hits         6925     6925           
  Misses        153      153           
  Partials       45       45           
Flag Coverage Δ
cpu 97.22% <ø> (ø)
pytest 97.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants