Skip to content

Added prefix argument to keywords tool#492

Merged
francescalb merged 12 commits intomasterfrom
prefixes-keywords-script
Feb 4, 2026
Merged

Added prefix argument to keywords tool#492
francescalb merged 12 commits intomasterfrom
prefixes-keywords-script

Conversation

@francescalb
Copy link
Contributor

Also changed previous prefix argument to write-prefixes, as that is what it did

Description

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Also changed previous prefix argument to write-prefixes,
as that is what it did
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.59%. Comparing base (342c440) to head (390960e).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
tripper/datadoc/keywords.py 6.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   84.71%   84.59%   -0.13%     
==========================================
  Files          30       30              
  Lines        4789     4796       +7     
==========================================
  Hits         4057     4057              
- Misses        732      739       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some changes. Nice implementation of the --prefix argument


kw = Keywords(theme=default_theme)

if args.prefix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

francescalb and others added 3 commits February 4, 2026 14:29
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
francescalb and others added 4 commits February 4, 2026 14:30
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a # pylint disable=too-many-statements.

See https://github.com/EMMC-ASBL/tripper/actions/runs/21673427410/job/62487043368?pr=492

Otherwise great!

@francescalb francescalb merged commit 5cc8784 into master Feb 4, 2026
20 of 22 checks passed
@francescalb francescalb deleted the prefixes-keywords-script branch February 4, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants