Merged
Conversation
…pper into allow-keyword-redefinition
For more information, see https://pre-commit.ci
…pper into allow-keyword-redefinition
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 84.84% 84.93% +0.08%
==========================================
Files 30 30
Lines 4567 4607 +40
==========================================
+ Hits 3875 3913 +38
- Misses 692 694 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…C/OpenModel/tripper into allow-keyword-redefinition
jesper-friis
approved these changes
Nov 16, 2025
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
For more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Desired behaviour:
It should be allowed to redfine keywords locally. This means that keywords in the default are overwritten. For instance: vcard:hasName can be overwritten to fam:hasName.
This behaviour is needed, but should be treated with care.
We use the argument
redefinewith thre possible values:'true' (warning issued), 'skip' (warning issued), 'raise' (default)
Default
raise: Raises an error to make sure that the choice of allowing redefinition of or skipping new of keywords is always an active choice .In practice this argument will often be set to true or skip, but by having the default False it should reduce the risk of doing it without intending to.
'true': existing keywords will be redefined, i.e. overwritten in the local context.
'skip': if a keyword that already is set is tried to be defined it will be skipped. This will typically happen if you have a prefLabel in your ontology that is the same as an existing keyword. With skip, this keyword will stay as the original. It should issue a warning and say that you should not use the keyword/preflabel alone for documentating this property/class but the curie.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.