Skip to content

Improved error message and fixed minor issue when reading data from PINK.#463

Merged
francescalb merged 2 commits intomasterfrom
minor-bugfix
Nov 10, 2025
Merged

Improved error message and fixed minor issue when reading data from PINK.#463
francescalb merged 2 commits intomasterfrom
minor-bugfix

Conversation

@jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Nov 7, 2025

Description

Mini-PR. Improved er message and fixed minor issue when reading data from PINK.

Updated test_fromdicts() to also test the case of missing "@type".

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (3f3ba09) to head (4d11f79).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #463   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files          30       30           
  Lines        4565     4567    +2     
=======================================
+ Hits         3873     3875    +2     
  Misses        692      692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jesper-friis jesper-friis changed the title Improved er message and fixed minor issue when reading data from PINK. Improved error message and fixed minor issue when reading data from PINK. Nov 9, 2025
@francescalb francescalb merged commit 32e3b54 into master Nov 10, 2025
22 checks passed
@francescalb francescalb deleted the minor-bugfix branch November 10, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants