Improved error message and fixed minor issue when reading data from PINK.#463
Merged
francescalb merged 2 commits intomasterfrom Nov 10, 2025
Merged
Improved error message and fixed minor issue when reading data from PINK.#463francescalb merged 2 commits intomasterfrom
francescalb merged 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
=======================================
Coverage 84.84% 84.84%
=======================================
Files 30 30
Lines 4565 4567 +2
=======================================
+ Hits 3873 3875 +2
Misses 692 692 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
francescalb
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mini-PR. Improved er message and fixed minor issue when reading data from PINK.
Updated test_fromdicts() to also test the case of missing "@type".
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.