Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 84.04% 84.84% +0.79%
==========================================
Files 30 30
Lines 4186 4565 +379
==========================================
+ Hits 3518 3873 +355
- Misses 668 692 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
francescalb
reviewed
Nov 7, 2025
francescalb
reviewed
Nov 7, 2025
Comment on lines
+259
to
+263
| """Load YAML file with keyword definitions. | ||
|
|
||
| Arguments: | ||
| yamlfile: Path of URL to a YAML file to load. | ||
| timeout: Timeout when accessing remote files. |
Contributor
There was a problem hiding this comment.
This goes into the documentation. Make a link to an example.
francescalb
reviewed
Nov 7, 2025
Comment on lines
+447
to
+451
| Arguments: | ||
| yamlfile: File to save keyword definitions to. | ||
| keywords: Sequence of keywords to include. | ||
| classes: Include keywords that have these classes in their domain. | ||
| themes: Include keywords for these themes. |
francescalb
reviewed
Nov 7, 2025
Comment on lines
+484
to
+492
| """Load keywords from a csv file. | ||
|
|
||
| Arguments: | ||
| filename: File to load. | ||
| format: File format. Unused. Only csv is currently supported. | ||
| prefixes: Dict with additional prefixes used by `dicts`. | ||
| theme: Theme defined by `dicts`. | ||
| basedOn: Theme(s) that `dicts` are based on. | ||
| kwargs: Keyword arguments passed on to TableDoc.parse_csv(). |
francescalb
reviewed
Nov 7, 2025
francescalb
reviewed
Nov 7, 2025
tripper/datadoc/keywords.py
Outdated
Comment on lines
806
to
807
| - list of keywords missing `ts` | ||
| - list of keywords existing `ts` |
Contributor
Author
There was a problem hiding this comment.
I see there is a typo. Apart from that, what doesn't make sense?
francescalb
requested changes
Nov 7, 2025
Contributor
francescalb
left a comment
francescalb
left a comment
There was a problem hiding this comment.
Probably fine. Since you write that it is impossible to review I won't do a proper review. Documentation needs to be improved so that people can see examples of inputs.
Tests are failing.
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
jesper-friis
commented
Nov 7, 2025
tripper/datadoc/keywords.py
Outdated
Comment on lines
806
to
807
| - list of keywords missing `ts` | ||
| - list of keywords existing `ts` |
Contributor
Author
There was a problem hiding this comment.
I see there is a typo. Apart from that, what doesn't make sense?
francescalb
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added new functionality to load and save keywords in several different representations. The the Keywords class has now the following set of methods:
load_yaml()|save_yaml(): The original keywords.yaml representation.load_rdf()|save_rdf(): RDF representation, e.g. turtle format.load_table()|save_table(): Tabular representation, e.g. csv format.save_context(): Save as JSON-LD context.save_markdown(): Save as markdown table (for documentation).Especially loading from ontologies and tables makes it much easier to define new keywords (rdf properties).
The PR includes many other bug-fixes and improvements making it almost impossible to review.
Things that could be interesting for a reviewer to look at are: