Skip to content

Added available() method and check_url to argument to Triplestore#437

Merged
jesper-friis merged 10 commits intomasterfrom
check-url
Oct 7, 2025
Merged

Added available() method and check_url to argument to Triplestore#437
jesper-friis merged 10 commits intomasterfrom
check-url

Conversation

@jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Sep 28, 2025

Description

Integrated checking if a backend service is available to the standard Triplestore API, by adding the available() method and check_url to argument to the Triplestore class.

The check_url configuration can now be configured together with other parameters in the session.

Simplified tests by using sessions and the new check_url configuration.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@jesper-friis jesper-friis mentioned this pull request Sep 28, 2025
10 tasks
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.88%. Comparing base (7996b53) to head (29d5fa9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   83.86%   83.88%   +0.01%     
==========================================
  Files          29       29              
  Lines        4109     4114       +5     
==========================================
+ Hits         3446     3451       +5     
  Misses        663      663              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


Arguments:
timeout: Total time in seconds to wait for a respond.
interval: Interval for checking response.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now updated the docstring to the following:

    interval: Internal time interval in seconds between checking if the
        service has responded.

Is that more understandable?

jesper-friis and others added 3 commits October 7, 2025 18:44
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
@jesper-friis jesper-friis merged commit f686db7 into master Oct 7, 2025
22 checks passed
@jesper-friis jesper-friis deleted the check-url branch October 7, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants